From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6651AC4338F for ; Tue, 10 Aug 2021 20:59:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EC89760724 for ; Tue, 10 Aug 2021 20:59:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EC89760724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 655268D0001; Tue, 10 Aug 2021 16:59:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 605496B0072; Tue, 10 Aug 2021 16:59:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F4E08D0001; Tue, 10 Aug 2021 16:59:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id 3237E6B0071 for ; Tue, 10 Aug 2021 16:59:44 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CCF251B030 for ; Tue, 10 Aug 2021 20:59:43 +0000 (UTC) X-FDA: 78460387446.20.88EDDA0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 7C5FFF00374A for ; Tue, 10 Aug 2021 20:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628629183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y1Vp/6OiBnakWJeS36BEKgxnmfXJ4RY91EtLxgXSPUk=; b=bGtC/98v0me+N871p/5kALjw16j0lmzuKc/BiK87C8PwFkqDxA4m5mxq6uFAumHU5bDZFe 8Q9fb7d8lc6mbYG2qKKTI9MzP7wWyZ6pNZGEqO/qVOjftOmjuh6vuJpD/Ub1Nikm6ANel5 +Ex1y+9AvbOL1926qOdfzgAP1UZv5Qs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-572-brpgYihDMKqjSicpROKpMA-1; Tue, 10 Aug 2021 16:59:41 -0400 X-MC-Unique: brpgYihDMKqjSicpROKpMA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AEBC587D54B; Tue, 10 Aug 2021 20:59:40 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9C52960C05; Tue, 10 Aug 2021 20:59:39 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-60-willy@infradead.org> References: <20210715033704.692967-60-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 059/138] mm/rmap: Add folio_mkclean() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1812064.1628629178.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 21:59:38 +0100 Message-ID: <1812065.1628629178@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7C5FFF00374A Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="bGtC/98v"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf16.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=dhowells@redhat.com X-Stat-Signature: jigy7cs81mjdxb3wi35igsgzsotnoijg X-HE-Tag: 1628629183-623057 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > Transform page_mkclean() into folio_mkclean() and add a page_mkclean() > wrapper around folio_mkclean(). > > folio_mkclean is 15 bytes smaller than page_mkclean, but the kernel > is enlarged by 33 bytes due to inlining page_folio() into each caller. > This will go away once the callers are converted to use folio_mkclean(). > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Reviewed-by: David Howells