From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2232C4338F for ; Tue, 10 Aug 2021 21:17:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9070060EBD for ; Tue, 10 Aug 2021 21:17:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9070060EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D1E348D0003; Tue, 10 Aug 2021 17:17:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCD7A6B0072; Tue, 10 Aug 2021 17:17:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBC5E8D0003; Tue, 10 Aug 2021 17:17:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id A24456B0071 for ; Tue, 10 Aug 2021 17:17:05 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5665A22888 for ; Tue, 10 Aug 2021 21:17:05 +0000 (UTC) X-FDA: 78460431210.06.B43E3C4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 0B026900802A for ; Tue, 10 Aug 2021 21:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628630224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M07184jKAvMxpfzMZ1dKXh+WpGAO8RO24s56vHQzw+s=; b=FabLCabPC3jdzHwrvOpe+0FQ1ALzf0RkAOca8K1ZHZskItg9Q1iV/WAgCYLKgOpFJDEquk apEsvDUPIkJkthX8vyW3UWfZtsV/jCPVGBKvYkocKD/Ptu0oQOQDa510x3kZCXLl0Wp9p/ l5LN8a4RqAekvsq+6SxPE7JVYy4LBks= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-434-7po_AAuOPrmO7ZYwl-BnwA-1; Tue, 10 Aug 2021 17:17:03 -0400 X-MC-Unique: 7po_AAuOPrmO7ZYwl-BnwA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 27503593C5; Tue, 10 Aug 2021 21:17:02 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 042E85D9C6; Tue, 10 Aug 2021 21:17:00 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-68-willy@infradead.org> References: <20210715033704.692967-68-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 067/138] mm/writeback: Add folio_start_writeback() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1812884.1628630220.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 22:17:00 +0100 Message-ID: <1812885.1628630220@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FabLCabP; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf29.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=dhowells@redhat.com X-Stat-Signature: zupm1x6uztq469w5h55ihobcju9di6w9 X-Rspamd-Queue-Id: 0B026900802A X-Rspamd-Server: rspam01 X-HE-Tag: 1628630224-689006 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > Rename set_page_writeback() to folio_start_writeback() to match > folio_end_writeback(). Do not bother with wrappers that return void; > callers are perfectly capable of ignoring return values. > > Add wrappers for set_page_writeback(), set_page_writeback_keepwrite() and > test_set_page_writeback() for compatibililty with existing filesystems. > The main advantage of this patch is getting the statistics right, > although it does eliminate a couple of calls to compound_head(). > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Reviewed-by: David Howells