From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D35FCC4338F for ; Tue, 10 Aug 2021 21:23:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 62DDD61077 for ; Tue, 10 Aug 2021 21:23:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 62DDD61077 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C526A8D0001; Tue, 10 Aug 2021 17:23:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C02096B0072; Tue, 10 Aug 2021 17:23:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF1478D0001; Tue, 10 Aug 2021 17:23:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id 95DC26B0071 for ; Tue, 10 Aug 2021 17:23:53 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4AFB9824999B for ; Tue, 10 Aug 2021 21:23:53 +0000 (UTC) X-FDA: 78460448346.40.2D344DE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf10.hostedemail.com (Postfix) with ESMTP id CE23B600B676 for ; Tue, 10 Aug 2021 21:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628630632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zl+SFxMBURzTNx0iFxg9wDAN9QWXIbjsgbL3OqA/y9s=; b=Hw0V2fzFZz4tu0YFVANSA06bCmLRysLacD3PRqEgwWuRLmzvPLdCbwsnrhZefC/0gxVv1B 3oXctYYSixE/Jhs/32O+Zg542krEtbeN4sOLUXGxPni73TCCgUyGU6GbvaNKVcdh87MVXy cBqoKEYuydBMnpOrw2RkYTf0cek+LZU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-357-RnWwPulcPtu7SNFoNycdsQ-1; Tue, 10 Aug 2021 17:23:50 -0400 X-MC-Unique: RnWwPulcPtu7SNFoNycdsQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 767D7801B3C; Tue, 10 Aug 2021 21:23:49 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4CCCB5D9C6; Tue, 10 Aug 2021 21:23:48 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-74-willy@infradead.org> References: <20210715033704.692967-74-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 073/138] mm/writeback: Add folio_cancel_dirty() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1813245.1628630627.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 22:23:47 +0100 Message-ID: <1813246.1628630627@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CE23B600B676 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hw0V2fzF; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf10.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=dhowells@redhat.com X-Stat-Signature: p3u6snu5t6p9i5d941897k4rbubcamt6 X-HE-Tag: 1628630632-347498 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > Turn __cancel_dirty_page() into __folio_cancel_dirty() and add wrappers. > Move the prototypes into pagemap.h since this is page cache functionality. > Saves 44 bytes of kernel text in total; 33 bytes from __folio_cancel_dirty > and 11 from two callers of cancel_dirty_page(). > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Reviewed-by: David Howells