From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA88AC4320A for ; Tue, 10 Aug 2021 21:34:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 50AEB610E9 for ; Tue, 10 Aug 2021 21:34:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 50AEB610E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id CE5EA6B0071; Tue, 10 Aug 2021 17:34:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C92E88D0001; Tue, 10 Aug 2021 17:34:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B81AF6B0073; Tue, 10 Aug 2021 17:34:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by kanga.kvack.org (Postfix) with ESMTP id 9BDFD6B0071 for ; Tue, 10 Aug 2021 17:34:58 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 460671E4DB for ; Tue, 10 Aug 2021 21:34:58 +0000 (UTC) X-FDA: 78460476276.38.8AE7E3D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id B2E2A4F84 for ; Tue, 10 Aug 2021 21:34:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628631297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cDJeQ1IVHivnnNjVy+6TxvfQSLwRaCeXGyL2mLJIpfs=; b=OKhbhIt6gPDKtGWw/IO/AZylIyu5BkYYRZaDu3syjcFkAXd3Anuf1QZNfgqCOG5APywcBB z+WSNa/UQM8pFryi1InvhRAhS03L0rpA1xyGNEhejHtr6rUZ9VfNuiK4sii97DEkJYeFXp dSegufzVZfB9cWL71kw6qAeQjiJKpT8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-10-5MSDVLBIOhmregoOV89k5g-1; Tue, 10 Aug 2021 17:34:53 -0400 X-MC-Unique: 5MSDVLBIOhmregoOV89k5g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D84236409B; Tue, 10 Aug 2021 21:34:52 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id A359527CA8; Tue, 10 Aug 2021 21:34:51 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-80-willy@infradead.org> References: <20210715033704.692967-80-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 079/138] mm/filemap: Add readahead_folio() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1813749.1628631290.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 22:34:50 +0100 Message-ID: <1813750.1628631290@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B2E2A4F84 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OKhbhIt6; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf22.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=dhowells@redhat.com X-Stat-Signature: 3xxs78y3gbko5smmze6z9rdawqsdj6u9 X-HE-Tag: 1628631297-400731 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > The pointers stored in the page cache are folios, by definition. > This change comes with a behaviour change -- callers of readahead_folio() > are no longer required to put the page reference themselves. This matches > how readpage works, rather than matching how readpages used to work. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig For some of the things I'm looking at, this is actually inconvenient, but I guess I can take an extra ref if I need it. Reviewed-by: David Howells