From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4261FC4338F for ; Tue, 10 Aug 2021 21:51:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C60C76056B for ; Tue, 10 Aug 2021 21:51:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C60C76056B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4E1008D0001; Tue, 10 Aug 2021 17:51:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 491166B0072; Tue, 10 Aug 2021 17:51:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37FA38D0001; Tue, 10 Aug 2021 17:51:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 1BBD06B0071 for ; Tue, 10 Aug 2021 17:51:29 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C42FD211B0 for ; Tue, 10 Aug 2021 21:51:28 +0000 (UTC) X-FDA: 78460517856.05.09D4180 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 646AEF003FFC for ; Tue, 10 Aug 2021 21:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628632287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WOJbDaOgR9A4WIv7Hr0VHIDUG6WaV2S/pWdNcf5TSwI=; b=KUIsjMlaoDGU/MWkIYNsaWtDWBnzHOK15ZtADUcmO0rlYj2AT7T9gn6IICak3MzrsdIs0m kcb4zL1fZHFFQMIArvr8uGhYXestHSVXL+bkAMIEPXTYLu6d2+20ROZMoUS6L+clFSQRfG 2/OVwLyhO9/sGxS0EUNHtwf9WSlH2I4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-T7ZIgILRO2iicsiT8o-PHw-1; Tue, 10 Aug 2021 17:51:26 -0400 X-MC-Unique: T7ZIgILRO2iicsiT8o-PHw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2258B1853026; Tue, 10 Aug 2021 21:51:25 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id F38C760BF1; Tue, 10 Aug 2021 21:51:23 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-85-willy@infradead.org> References: <20210715033704.692967-85-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 084/138] mm/page_alloc: Add folio allocation functions MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1814545.1628632283.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 22:51:23 +0100 Message-ID: <1814546.1628632283@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 646AEF003FFC Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KUIsjMla; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf11.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=dhowells@redhat.com X-Stat-Signature: 3ftpq15611ynks8sd46br5zmzm5jhdt3 X-HE-Tag: 1628632288-856363 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > +struct folio *folio_alloc(gfp_t gfp, unsigned order) > +{ > + struct page *page = alloc_pages(gfp | __GFP_COMP, order); > + > + if (page && order > 1) > + prep_transhuge_page(page); Ummm... Shouldn't order==1 pages (two page folios) be prep'd also? > + return (struct folio *)page; > +} Would it be better to just jump to alloc_pages() if order <= 1? E.g.: struct folio *folio_alloc(gfp_t gfp, unsigned order) { struct page *page; if (order <= 1) return (struct folio *)alloc_pages(gfp | __GFP_COMP, order); page = alloc_pages(gfp | __GFP_COMP, order); if (page) prep_transhuge_page(page); return (struct folio *)page; } David