From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81C71C4338F for ; Tue, 10 Aug 2021 22:05:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1346461008 for ; Tue, 10 Aug 2021 22:05:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1346461008 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 804896B0072; Tue, 10 Aug 2021 18:05:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B4AE6B0073; Tue, 10 Aug 2021 18:05:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A3878D0001; Tue, 10 Aug 2021 18:05:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id 4D83E6B0072 for ; Tue, 10 Aug 2021 18:05:39 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 04BCD824999B for ; Tue, 10 Aug 2021 22:05:39 +0000 (UTC) X-FDA: 78460553598.36.930A1B5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 971E8100BF87 for ; Tue, 10 Aug 2021 22:05:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628633137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KlRVFcfsiPZEuz6J4GfZil/2Tt8hvbgnI3Yitqd2JX8=; b=gtxVXoeWiDTShqsmBlLWZiGfwpCRevDmHv9I7Lrs4b2mKUKuyCR5vyGWIqD1StlT2mnf02 ryTQt39wAPvOcFgZjuIcaUSuWpAyCyFR4qCoF6bY4J8Dk7ARgm8ux9t/dI94dxKmPjxAF4 yZAajtXQwB6atTWJTqJH75X8rAho1Cc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-367-fMf0dIkKOKW7rilvcogtaw-1; Tue, 10 Aug 2021 18:05:36 -0400 X-MC-Unique: fMf0dIkKOKW7rilvcogtaw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E8258042EB; Tue, 10 Aug 2021 22:05:35 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 854FC5D9CA; Tue, 10 Aug 2021 22:05:34 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-89-willy@infradead.org> References: <20210715033704.692967-89-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 088/138] mm/filemap: Add filemap_get_folio MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1815134.1628633133.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 23:05:33 +0100 Message-ID: <1815135.1628633133@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gtxVXoeW; spf=none (imf13.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 971E8100BF87 X-Stat-Signature: 6xdd76rd5exnpdi4sz68xuzkbzts81u5 X-HE-Tag: 1628633138-189407 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > filemap_get_folio() is a replacement for find_get_page(). > Turn pagecache_get_page() into a wrapper around __filemap_get_folio(). > Remove find_lock_head() as this use case is now covered by > filemap_get_folio(). > > Reduces overall kernel size by 209 bytes. __filemap_get_folio() is > 316 bytes shorter than pagecache_get_page() was, but the new > pagecache_get_page() is 99 bytes longer, one presumes. > . > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: David Howells