From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A881C433C1 for ; Mon, 22 Mar 2021 09:25:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7643D60233 for ; Mon, 22 Mar 2021 09:25:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7643D60233 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F2F2F6B0093; Mon, 22 Mar 2021 05:06:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE04D6B0095; Mon, 22 Mar 2021 05:06:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D46F46B0096; Mon, 22 Mar 2021 05:06:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id B65176B0093 for ; Mon, 22 Mar 2021 05:06:57 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1F0F518002072 for ; Mon, 22 Mar 2021 09:25:48 +0000 (UTC) X-FDA: 77946977976.12.8AB5E42 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 8664E200024F for ; Mon, 22 Mar 2021 09:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616405147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AM5PYcagQbtDg3NrFzWha9n5u8jY/mxXCcbX0fzIUlk=; b=gXoKHWhrtvJzeylDs5Yvxc1j9voPuiSMG4pnWZ96ccO786/KnEyJBlFYjiAiW56ebbz/jZ sD+lMXJSBOVbIDjiHyL1qCT/t9victoCn39IiMlzNTZe8yB07h8mCK8jb7LJZye/E/dJ1c yooKApqrXlm5vHKrxPkfdlKK915i3VM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-249-c39_QNLyMOaD17Z6n2Owsg-1; Mon, 22 Mar 2021 05:25:45 -0400 X-MC-Unique: c39_QNLyMOaD17Z6n2Owsg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 65115108BD06; Mon, 22 Mar 2021 09:25:43 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-58.rdu2.redhat.com [10.10.112.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id AAD2B2CE8A; Mon, 22 Mar 2021 09:25:36 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210320054104.1300774-2-willy@infradead.org> References: <20210320054104.1300774-2-willy@infradead.org> <20210320054104.1300774-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v5 01/27] fs/cachefiles: Remove wait_bit_key layout dependency MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1878126.1616405135.1@warthog.procyon.org.uk> Date: Mon, 22 Mar 2021 09:25:35 +0000 Message-ID: <1878127.1616405135@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Stat-Signature: bqr3fxaurux5d5zhstwr7tru75rtrhj1 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8664E200024F Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616405147-734159 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > Cachefiles was relying on wait_page_key and wait_bit_key being the > same layout, which is fragile. Now that wait_page_key is exposed in > the pagemap.h header, we can remove that fragility > > Signed-off-by: Matthew Wilcox (Oracle) Acked-and-tested-by: David Howells I wonder if this could be pushed directly to Linus now since we're relying on two different structs being compatible.