From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92577C433FE for ; Tue, 22 Nov 2022 15:35:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02BD96B0071; Tue, 22 Nov 2022 10:35:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F1EB86B0073; Tue, 22 Nov 2022 10:35:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0DC16B0074; Tue, 22 Nov 2022 10:35:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D1EC66B0071 for ; Tue, 22 Nov 2022 10:35:40 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 55D22AB804 for ; Tue, 22 Nov 2022 15:35:40 +0000 (UTC) X-FDA: 80161478040.08.509941F Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf13.hostedemail.com (Postfix) with ESMTP id B5FD720003 for ; Tue, 22 Nov 2022 15:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669131338; x=1700667338; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=2tW2G1a+1TR8Etq8K8ec13/rDo30wsBLYx7iORND+kY=; b=hlY88MEKv4ZC9L3B7aFoZ4779asTGNGr2Y8yykeAx2uVL5Pjx5RuU8Ty ok8Z8YnxTT0dbaBmaC8IQsjNrJowFGMX5GUeKqoRT3rJ8flGIEpKphoaH F1CP2Ge6Ol51prNSxv3J+nnApAtJFHCrEvAMHqYrEg++tShioUogloLmS Fxx4mGCLIgnr+4eZHUrCvRfgsseJKlTieJOpD4+CTzkIikRHa8Ugm7+YQ Un4wrP5piq7DDtDHSadk2lN5q13iMhScoA34NcbXrnggktObI8Bsic5RG WLHv/d5GPYCtg2C3iapc6BZvqVMG46YzGPfeh9+lpmzOXyMdhFG5/ng/w Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="313873061" X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="313873061" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2022 07:35:36 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="592179088" X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="592179088" Received: from lcano-mobl1.amr.corp.intel.com (HELO [10.255.231.75]) ([10.255.231.75]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2022 07:35:34 -0800 Message-ID: <19d93ff0-df0d-dc9d-654b-a9ca6f7be1d0@intel.com> Date: Tue, 22 Nov 2022 07:35:33 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 04/20] x86/virt/tdx: Add skeleton to initialize TDX on demand Content-Language: en-US To: Thomas Gleixner , Peter Zijlstra , Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: <87edtvgu1l.ffs@tglx> From: Dave Hansen In-Reply-To: <87edtvgu1l.ffs@tglx> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669131339; a=rsa-sha256; cv=none; b=7Q+jHdSEydkAwrCAL4ikltI41f+aBVS3D2URBR2gu5Wg8iRJJq+txgMKojpwcYLECwWtxW 41xS43hibRbG1YMvHeV0DgO35lG2+PZb7DpHqqKYp3mG8e6+tQzeLapkdzl37tOYKxB1Bv yKpBQf0yJaDbiSu/VcUSlEDBLvPZ+BI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=hlY88MEK; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669131339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cxwz9ecRlGx8UwLrRuTIXc1ynpgPLciHnLXn7vAKqbM=; b=VR2stnoK3gLzCbNgud6rqFvEq9YXvduWFU05JcBE7zOr7Qsk60kOxAWbAU239pFU5oWwmy ZBZEWnW3Yahwt+zsMeiIP+PXYreDkqb+BLjhHGECEyBJmd+x0kKAWKHUFnb2i/x/6QpEZL fjYhOmBXoO/CHXgZb0Wbi83EHkn/65U= Authentication-Results: imf13.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=hlY88MEK; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=dave.hansen@intel.com X-Stat-Signature: 3ghdxihomje8ocdaetbsgaq4brn9ydcb X-Rspamd-Queue-Id: B5FD720003 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1669131338-400442 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/22/22 02:31, Thomas Gleixner wrote: > Nothing in the TDX specs and docs mentions physical hotplug or a > requirement for invoking seamcall on the world. The TDX module source is actually out there[1] for us to look at. It's in a lovely, convenient zip file, but you can read it if sufficiently motivated. It has this lovely nugget in it: WARNING!!! Proprietary License!! Avert your virgin eyes!!! > if (tdx_global_data_ptr->num_of_init_lps < tdx_global_data_ptr->num_of_lps) > { > TDX_ERROR("Num of initialized lps %d is smaller than total num of lps %d\n", > tdx_global_data_ptr->num_of_init_lps, tdx_global_data_ptr->num_of_lps); > retval = TDX_SYS_CONFIG_NOT_PENDING; > goto EXIT; > } tdx_global_data_ptr->num_of_init_lps is incremented at TDH.SYS.INIT time. That if() is called at TDH.SYS.CONFIG time to help bring the module up. So, I think you're right. I don't see the docs that actually *explain* this "you must seamcall all the things" requirement. 1. https://www.intel.com/content/www/us/en/developer/articles/technical/intel-trust-domain-extensions.html