From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF7A5C2D0E2 for ; Wed, 23 Sep 2020 13:58:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6BA452220D for ; Wed, 23 Sep 2020 13:58:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BA452220D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8A5456B0068; Wed, 23 Sep 2020 09:58:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 855016B006C; Wed, 23 Sep 2020 09:58:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76AF06B006E; Wed, 23 Sep 2020 09:58:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id 61CDF6B0068 for ; Wed, 23 Sep 2020 09:58:54 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 16FF8181AEF09 for ; Wed, 23 Sep 2020 13:58:54 +0000 (UTC) X-FDA: 77294482188.16.brain34_56149b127156 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id ECF8710150EFD for ; Wed, 23 Sep 2020 13:58:53 +0000 (UTC) X-HE-Tag: brain34_56149b127156 X-Filterd-Recvd-Size: 3588 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Sep 2020 13:58:53 +0000 (UTC) IronPort-SDR: Y/kKR6xTKISLrVCkgYlkIVIvM7UYVGSpp/jy6JDgzG7FqVMCT7MD/pG1X2LQbTgtIwTHLr+rYT yQVcjz18MwQQ== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="178965127" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="178965127" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 06:58:51 -0700 IronPort-SDR: DOZNQUTwNmS6CdTEWIoW9qi7Sh22K+ola1js+j+Vn7PmZQGNyFPiXcYUQXMNKslnCfCP8vR0bU ku9o4NuN7J+w== X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="486449272" Received: from yymichae-mobl.ger.corp.intel.com (HELO [10.214.208.219]) ([10.214.208.219]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 06:58:46 -0700 Subject: Re: [Intel-gfx] [PATCH 4/6] drm/i915: use vmap in i915_gem_object_map To: Christoph Hellwig Cc: Andrew Morton , Juergen Gross , Stefano Stabellini , linux-mm@kvack.org, Peter Zijlstra , intel-gfx@lists.freedesktop.org, x86@kernel.org, linux-kernel@vger.kernel.org, Minchan Kim , dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, Boris Ostrovsky , Nitin Gupta References: <20200918163724.2511-1-hch@lst.de> <20200918163724.2511-5-hch@lst.de> <9b5d40af-7378-9e68-ca51-73b2148287f3@linux.intel.com> <20200923134117.GB9893@lst.de> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <1a421e7f-6255-c534-5403-715c2e809bd0@linux.intel.com> Date: Wed, 23 Sep 2020 14:58:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200923134117.GB9893@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23/09/2020 14:41, Christoph Hellwig wrote: > On Wed, Sep 23, 2020 at 10:52:33AM +0100, Tvrtko Ursulin wrote: >> >> On 18/09/2020 17:37, Christoph Hellwig wrote: >>> i915_gem_object_map implements fairly low-level vmap functionality in >>> a driver. Split it into two helpers, one for remapping kernel memory >>> which can use vmap, and one for I/O memory that uses vmap_pfn. >>> >>> The only practical difference is that alloc_vm_area prefeaults the >>> vmalloc area PTEs, which doesn't seem to be required here for the >>> kernel memory case (and could be added to vmap using a flag if actually >>> required). >> >> Patch looks good to me. >> >> Series did not get a CI run from our side because of a different base so I >> don't know if you would like to have a run there? If so you would need to >> rebase against git://anongit.freedesktop.org/drm-tip drm-tip and you could >> even send a series to intel-gfx-trybot@lists.freedesktop.org, suppressing >> cc, to check it out without sending a copy to the real mailing list. > > It doesn't seem like I can post to any freedesktop list, as I always > get rejection messages. But I'll happily prepare a branch if one > of you an feed it into your CI. That's fine, just ping me and I will forward it for testing, thanks! Regards, Tvrtko