From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 415E9C433E0 for ; Thu, 4 Mar 2021 11:59:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A86F964F2B for ; Thu, 4 Mar 2021 11:59:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A86F964F2B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 08BFA6B0005; Thu, 4 Mar 2021 06:59:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03B686B0006; Thu, 4 Mar 2021 06:59:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF75E6B0007; Thu, 4 Mar 2021 06:59:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id C31816B0005 for ; Thu, 4 Mar 2021 06:59:21 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 81A8AA2AD for ; Thu, 4 Mar 2021 11:59:21 +0000 (UTC) X-FDA: 77882046522.12.E79567C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf30.hostedemail.com (Postfix) with ESMTP id B1CFDE0011C5 for ; Thu, 4 Mar 2021 11:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614859160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/MJvftENZSyG+T/fhjBwVMMf0E/2ReNg/vCq6tR49zo=; b=G5BD0q4oJM1RxGq2scYJaooPlIDGPZBAAGDcTToh0oIFMB24Qvlll9+yhTtRW5J7YEDPKO QDkqo28XXXIJTnA3RIg5VzobHwUAUVRkkOLHSf5vsycmdEcC1v/4W8VF+pa1ySHb0F2lml iMRbb82Rm51sMJB6Or/vXl18I2ozvIs= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-577-34CyIgnWMjGnra0WTaAnmA-1; Thu, 04 Mar 2021 06:59:12 -0500 X-MC-Unique: 34CyIgnWMjGnra0WTaAnmA-1 Received: by mail-ej1-f69.google.com with SMTP id 3so12061857ejx.17 for ; Thu, 04 Mar 2021 03:59:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/MJvftENZSyG+T/fhjBwVMMf0E/2ReNg/vCq6tR49zo=; b=ZhK6RPNtkyE5GbzJ8kTnMelldd6K2WzsYaCaoM/3/VqZsfKg6CfTRd5znDBEqGpoIS LqB08lDL4P4EFciihvNJ3PoOizr1XlWLKojaBzoUb+BDJxQKjtpqvxsTzN8xWfvBlBN5 HJRF7ddIJnAoR1wniRZIlJZfaR0pf5/zgjGbRmuCuVHKRAmWH0Vwcj7uDgm1GI4CNbUM cwrW20vzwidh3454P4tD0pfm/zNapJGkJkczDzVcSOJMxKYcb+0GUDwobWJwbdOxqDkG x6ngy0VXuBmL6FYJPoGa3sLQtcqrSa7o3DyND3BjtkDllEqbuqKBC4ItGtKbTHjf6+S9 5B3A== X-Gm-Message-State: AOAM531LsC4y79/qK6WGluvBQF8AyYHZSokPWdhEEVrFouopPgn3Uj/J /l8BiRIPwPQM9avazxpJR6qy7cA433zmmLuPLWPM0uIyH7yFKiqivcnCw9twV34pl5gJSum8YUM yovMuBdbljOicBDJhtIhHuNtg73HViV58sZmFO8PfuNs9OtCnSowWtiJ+E1oz3RA= X-Received: by 2002:a50:bf42:: with SMTP id g2mr3861265edk.101.1614859150153; Thu, 04 Mar 2021 03:59:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJyv759vOCqqRBe5m2/dptK1HIIHHJVjhhVC2i83CzTe6LxC1y+BP/muuEkwc8PolNSeltOkDA== X-Received: by 2002:a50:bf42:: with SMTP id g2mr3861246edk.101.1614859149833; Thu, 04 Mar 2021 03:59:09 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id i6sm19633067ejz.95.2021.03.04.03.59.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Mar 2021 03:59:09 -0800 (PST) Subject: Re: [linux-next:master 7714/11865] drivers/platform/x86/dell/dell-smbios-smm.c:27:35: warning: unused variable 'dell_device_table' To: kernel test robot , Mario Limonciello Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List References: <202102202323.OkXTM7bf-lkp@intel.com> From: Hans de Goede Message-ID: <1b24561f-5d9d-dcfb-a231-11be10722074@redhat.com> Date: Thu, 4 Mar 2021 12:59:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <202102202323.OkXTM7bf-lkp@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B1CFDE0011C5 X-Stat-Signature: jadjjz3xp3x6ok1o3tftchjzrbucanex Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614859158-863398 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 2/20/21 4:16 PM, kernel test robot wrote: > Hi Mario, > > First bad commit (maybe != root cause): > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: abaf6f60176f1ae9d946d63e4db63164600b7b1a > commit: f1e1ea516721d1ea0b21327ff9e6cb2c2bb86e28 [7714/11865] platform/x86: Move all dell drivers to their own subdirectory > config: x86_64-randconfig-r014-20210220 (attached as .config) > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install x86_64 cross compiling tool for clang build > # apt-get install binutils-x86-64-linux-gnu > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=f1e1ea516721d1ea0b21327ff9e6cb2c2bb86e28 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout f1e1ea516721d1ea0b21327ff9e6cb2c2bb86e28 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > >>> drivers/platform/x86/dell/dell-smbios-smm.c:27:35: warning: unused variable 'dell_device_table' [-Wunused-const-variable] > static const struct dmi_system_id dell_device_table[] __initconst = { > ^ > 1 warning generated. So this table is only there so that it can be passed to the MODULE_DEVICE_TABLE() macro for auto-loading the module. I guess that that macro used to give enough of a reference to the table for the compiler to not complain but that seems to have changed. I suggest that we just add an __maybe_unused to the declaration of the table to silence the warning. Regards, Hans > > > vim +/dell_device_table +27 drivers/platform/x86/dell/dell-smbios-smm.c > > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 26 > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 @27 static const struct dmi_system_id dell_device_table[] __initconst = { > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 28 { > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 29 .ident = "Dell laptop", > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 30 .matches = { > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 31 DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 32 DMI_MATCH(DMI_CHASSIS_TYPE, "8"), > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 33 }, > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 34 }, > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 35 { > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 36 .matches = { > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 37 DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 38 DMI_MATCH(DMI_CHASSIS_TYPE, "9"), /*Laptop*/ > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 39 }, > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 40 }, > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 41 { > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 42 .matches = { > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 43 DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 44 DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /*Notebook*/ > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 45 }, > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 46 }, > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 47 { > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 48 .ident = "Dell Computer Corporation", > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 49 .matches = { > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 50 DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"), > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 51 DMI_MATCH(DMI_CHASSIS_TYPE, "8"), > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 52 }, > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 53 }, > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 54 { } > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 55 }; > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 56 MODULE_DEVICE_TABLE(dmi, dell_device_table); > 549b4930f05765 drivers/platform/x86/dell-smbios-smm.c Mario Limonciello 2017-11-01 57 > > :::::: The code at line 27 was first introduced by commit > :::::: 549b4930f057658dc50d8010e66219233119a4d8 platform/x86: dell-smbios: Introduce dispatcher for SMM calls > > :::::: TO: Mario Limonciello > :::::: CC: Darren Hart (VMware) > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >