From: David Hildenbrand <david@redhat.com>
To: Oscar Salvador <osalvador@suse.de>, akpm@linux-foundation.org
Cc: mhocko@suse.com, anthony.yznaga@oracle.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm,memory_hotplug: Explicitly pass the head to isolate_huge_page
Date: Mon, 11 Feb 2019 09:58:56 +0100 [thread overview]
Message-ID: <1b36e2a9-daf4-ed39-88da-f95fb0d25171@redhat.com> (raw)
In-Reply-To: <20190208090604.975-1-osalvador@suse.de>
On 08.02.19 10:06, Oscar Salvador wrote:
> isolate_huge_page() expects we pass the head of hugetlb page to it:
>
> bool isolate_huge_page(...)
> {
> ...
> VM_BUG_ON_PAGE(!PageHead(page), page);
> ...
> }
>
> While I really cannot think of any situation where we end up with a
> non-head page between hands in do_migrate_range(), let us make sure
> the code is as sane as possible by explicitly passing the Head.
> Since we already got the pointer, it does not take us extra effort.
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> ---
> mm/memory_hotplug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 656ff386ac15..d5f7afda67db 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1378,12 +1378,12 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
>
> if (PageHuge(page)) {
> struct page *head = compound_head(page);
> - pfn = page_to_pfn(head) + (1<<compound_order(head)) - 1;
> if (compound_order(head) > PFN_SECTION_SHIFT) {
> ret = -EBUSY;
> break;
> }
> - isolate_huge_page(page, &source);
> + pfn = page_to_pfn(head) + (1<<compound_order(head)) - 1;
> + isolate_huge_page(head, &source);
> continue;
> } else if (PageTransHuge(page))
> pfn = page_to_pfn(compound_head(page))
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-02-11 8:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 9:06 [PATCH] mm,memory_hotplug: Explicitly pass the head to isolate_huge_page Oscar Salvador
2019-02-11 8:58 ` David Hildenbrand [this message]
2019-02-12 8:33 ` Michal Hocko
2019-02-12 13:45 ` Oscar Salvador
2019-02-12 14:40 ` Michal Hocko
2019-02-13 0:13 ` Mike Kravetz
2019-02-13 8:13 ` Oscar Salvador
2019-02-13 12:33 ` Michal Hocko
2019-02-13 15:15 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b36e2a9-daf4-ed39-88da-f95fb0d25171@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anthony.yznaga@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).