From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33F01C63793 for ; Thu, 22 Jul 2021 07:27:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CF6046127C for ; Thu, 22 Jul 2021 07:27:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF6046127C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 19B586B0033; Thu, 22 Jul 2021 03:27:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14BB36B005D; Thu, 22 Jul 2021 03:27:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0126B6B006C; Thu, 22 Jul 2021 03:27:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id D8B1D6B0033 for ; Thu, 22 Jul 2021 03:27:55 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6AFA520311 for ; Thu, 22 Jul 2021 07:27:55 +0000 (UTC) X-FDA: 78389394510.03.57B8C80 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 07582D00BD38 for ; Thu, 22 Jul 2021 07:27:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626938874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NuYrCi1bGgu0nFjnpZvjg5LiT0x0KF4sMzShLMpaSQc=; b=W6fANIAtcYwBed/yDTMMmuerBlGaoEOAHBC9rF6TIVtOBsjnpB55BPQpKgeGLxqiTLCYtD SycZL72hfTmK9bbAKqvBtEA05mcEHTV/Z+EMXIxpYryFvKMnapMvBjY3RjyLAElrQAdrtn f0Fy9GG0dK0iS3PiNgy84NHthedbSs0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-383-v880MA4uOV68ZGGCt9YZNQ-1; Thu, 22 Jul 2021 03:27:53 -0400 X-MC-Unique: v880MA4uOV68ZGGCt9YZNQ-1 Received: by mail-wr1-f69.google.com with SMTP id i10-20020a5d55ca0000b029013b976502b6so2116975wrw.2 for ; Thu, 22 Jul 2021 00:27:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=NuYrCi1bGgu0nFjnpZvjg5LiT0x0KF4sMzShLMpaSQc=; b=knQvK+UqjVYbx2Zd9VO0XpB1mcIneKE4LS1OM9h21/ubM+rHVUskhCTKFGimts4LrL vF583JmXlx+O+ELcif9fWn+ZhOhavMhgejUuDUoIs9ERBrbYyALNT4n7EGCvMJwJ7u7Y SoIbgOA1Qp8r0eDqTDY7jn7cb6Vl8mPUniBjSHLDm+y0+E+mTfJKNt6NC/sOH1nVlElZ R7Fl+MQU2mNediVQxQ2huxBdHJ2ibyZL37wEFrUfGGx4SrwEvvBqyxyrtOPq2QsO6BNu VnGGfyZoky/7um/3+p2wuZhIM+Xena5y20g58J7mvBN2NZOdCnaA4nbYFOurmboje5C4 j/cw== X-Gm-Message-State: AOAM530HZRAIgELm2mHXQe3eEdoVWJp7EvrbU5XHhwZ4yno0YKo8LyKi VHcDXkdj6+NKopb6iyeK8IL0jZTj9/jEZ4qj8K6FkvFKuPXZQr2/CjOTxG5KqlAWVQlhoNNVy9b 4CuOtjH/U2e4= X-Received: by 2002:adf:b1c5:: with SMTP id r5mr3273380wra.146.1626938871918; Thu, 22 Jul 2021 00:27:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhkQXINpTWPDA6quLtB1Hcr3Niuqs4vsXHq62DLDLjmOizltRViJgQP3PvnxKLEhuU657QSw== X-Received: by 2002:adf:b1c5:: with SMTP id r5mr3273365wra.146.1626938871734; Thu, 22 Jul 2021 00:27:51 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6970.dip0.t-ipconnect.de. [91.12.105.112]) by smtp.gmail.com with ESMTPSA id z6sm17306789wrw.9.2021.07.22.00.27.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jul 2021 00:27:51 -0700 (PDT) Subject: Re: [PATCH] mm/migrate: fix page state accounting type conversion underflow To: Nicholas Piggin , Andrew Morton Cc: Mel Gorman , Yang Shi , linux-mm@kvack.org, Alexey Kardashevskiy References: <20210722054840.501423-1-npiggin@gmail.com> From: David Hildenbrand Organization: Red Hat Message-ID: <1bc9f24a-c6ff-902e-bce0-165c235bb643@redhat.com> Date: Thu, 22 Jul 2021 09:27:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210722054840.501423-1-npiggin@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W6fANIAt; spf=none (imf15.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Stat-Signature: k17ib5kq31c6ogxoiofwmhuukjwpnfbh X-Rspamd-Queue-Id: 07582D00BD38 X-HE-Tag: 1626938874-328593 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.07.21 07:48, Nicholas Piggin wrote: > Similarly to commit 2da9f6305f306 ("mm/vmscan: fix NR_ISOLATED_FILE > corruption on 64-bit"), fix -ve int -> unsigned int -> long bug. > > Reported-by: Alexey Kardashevskiy > Fixes: c5fc5c3ae0c84 ("mm: migrate: account THP NUMA migration counters correctly") > Signed-off-by: Nicholas Piggin > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 34a9ad3e0a4f..7e240437e7d9 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2068,7 +2068,7 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, > LIST_HEAD(migratepages); > new_page_t *new; > bool compound; > - unsigned int nr_pages = thp_nr_pages(page); > + int nr_pages = thp_nr_pages(page); > > /* > * PTE mapped THP or HugeTLB page can't reach here so the page could > This is too fragile to silently break again IMHO. Should we similarly to 2da9f6305f306 handle the conversion explicitly inside the mod_node_page_state() call? -- Thanks, David / dhildenb