From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C628C433DF for ; Thu, 8 Oct 2020 18:11:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB400221FE for ; Thu, 8 Oct 2020 18:11:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PhCVwNEQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB400221FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4C1066B005C; Thu, 8 Oct 2020 14:11:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46FD86B005D; Thu, 8 Oct 2020 14:11:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 386F26B0062; Thu, 8 Oct 2020 14:11:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 0C99A6B005C for ; Thu, 8 Oct 2020 14:11:30 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 767971EE6 for ; Thu, 8 Oct 2020 18:11:29 +0000 (UTC) X-FDA: 77349550698.20.spy31_041412d271da Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 44EA4180C060D for ; Thu, 8 Oct 2020 18:11:29 +0000 (UTC) X-HE-Tag: spy31_041412d271da X-Filterd-Recvd-Size: 4583 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Thu, 8 Oct 2020 18:11:28 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id d24so3784412ljg.10 for ; Thu, 08 Oct 2020 11:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=G3mrHFgsl4yRBSpBY2KK+yE6uxmlc+TxwEDQsNmv4cc=; b=PhCVwNEQPJOov0cSmL537oCIOTrYgAe4jM+pmEbETQZDP2DHFu8p2t5cROBpiAGJPg Yo/yGIIYiuK5Gtnh6JkTAjANM6mZjLgyZ1Qp/nzVsOgDBbjDhk9epotbdyztKO7s3jH/ HpXV4FGK4pTp6il0zGS8nLgpfztWn/mesNVDAAACvfXeOyvVRavwGju/AEaCeBb/3xUE C70X92MMFGQevzm3dK1C0anSPhkJGHLY4p2K5DVHhfXGBXPmEbtFJI3toCeeiak7RXlF uuUhGpj1uXd/SPuPz14ehDlle7QxEkf8FrxrHIgpo+wzqRw837ePeNEuFL7RN/5+ZHvw p6bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=G3mrHFgsl4yRBSpBY2KK+yE6uxmlc+TxwEDQsNmv4cc=; b=YTlO6QC3gCHVnEYCDnA/5FtuEGJwq8tqZYqsTfpiWG7aFuhVctGUC5lEaUIXi7fYZ1 FJZpJe2ixWsPgij04bk2NrQu2nbc8IqtmoNqgdGSkJXd4DnT4lT9aRPVdc+azrAp1SDi ApdYaUqqzcoTI6RakSkZhvj49XaxQmaj0xyKfUtffuAV+SGX6Zv6mE6FAh8InS0xe+QG /uzwCsVkhdzf0apoA0pw2HzmZk2f2lJ7eH1uSV7ZHQYxWZvKUuSjq8Xunqoq0QPBbwfd p1cvAtZP+zhNl98expJ6hpTMDZcvT8MmG/EQu7VpCQT8XODty7Ra9tL9rB9gxbsSHs4n 5SjA== X-Gm-Message-State: AOAM533xnEUA2wCqIv3EBO4e57HBC8LEGtw1/vTxY6rsaZpYfxkMZuXO 1g496qzqJE02mu7LTxRkH8A= X-Google-Smtp-Source: ABdhPJz1UBLxdWzx8/hYgAzppJLKkNeg+nW+R08uBrpCVJSk6ut97gWc1kHPX8suMHfg7491c84EEg== X-Received: by 2002:a2e:82c8:: with SMTP id n8mr3998729ljh.62.1602180687184; Thu, 08 Oct 2020 11:11:27 -0700 (PDT) Received: from [192.168.1.112] (88-114-211-119.elisa-laajakaista.fi. [88.114.211.119]) by smtp.gmail.com with ESMTPSA id e19sm992864lfd.200.2020.10.08.11.11.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Oct 2020 11:11:26 -0700 (PDT) Subject: Re: [PATCH RESEND v2] mm: Optional full ASLR for mmap() and mremap() To: Matthew Wilcox Cc: linux-hardening@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20201008165408.38228-1-toiwoton@gmail.com> <20201008170728.GK20115@casper.infradead.org> From: Topi Miettinen Message-ID: <1d08abd1-4343-59e7-108a-68af5f7778c0@gmail.com> Date: Thu, 8 Oct 2020 21:11:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201008170728.GK20115@casper.infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8.10.2020 20.07, Matthew Wilcox wrote: > On Thu, Oct 08, 2020 at 07:54:08PM +0300, Topi Miettinen wrote: >> +3 Additionally enable full randomization of memory mappings created >> + with mmap(NULL, ...). With 2, the base of the VMA used for such >> + mappings is random, but the mappings are created in predictable >> + places within the VMA and in sequential order. With 3, new VMAs >> + are created to fully randomize the mappings. Also mremap(..., >> + MREMAP_MAYMOVE) will move the mappings even if not necessary. >> + >> + On 32 bit systems this may cause problems due to increased VM >> + fragmentation if the address space gets crowded. > > On all systems, it will reduce performance and increase memory usage due > to less efficient use of page tables and inability to merge adjacent VMAs > with compatible attributes. Right, I'll update the description. >> + if ((flags & MREMAP_MAYMOVE) && randomize_va_space >= 3) { >> + /* >> + * Caller is happy with a different address, so let's >> + * move even if not necessary! >> + */ >> + new_addr = arch_mmap_rnd(); >> + >> + ret = mremap_to(addr, old_len, new_addr, new_len, >> + &locked, flags, &uf, &uf_unmap_early, >> + &uf_unmap); >> + goto out; >> + } >> + >> + > > Overly enthusiastic newline > Will remove. -Topi