From: Zaslonko Mikhail <zaslonko@linux.ibm.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
borntraeger@de.ibm.com, gor@linux.ibm.com, hca@linux.ibm.com,
iii@linux.ibm.com, linux-mm@kvack.org, lkp@intel.com,
mm-commits@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [patch 01/12] zlib: export S390 symbols for zlib modules
Date: Tue, 8 Dec 2020 09:19:08 +0100 [thread overview]
Message-ID: <1d4cccc2-5e71-d09b-9b1b-03f30427af56@linux.ibm.com> (raw)
In-Reply-To: <45544373-754c-ad37-e020-f4864b963852@infradead.org>
On 08.12.2020 01:45, Randy Dunlap wrote:
> On 12/7/20 1:03 AM, Zaslonko Mikhail wrote:
>> Hello,
>>
>> should we probably put these to lib/zlib_dfltcc/dfltcc_syms.c along with the other EXPORT_SYMBOL statements?
>
> Hi,
> I didn't know about that file. :)
>
> That change makes sense. At least that's how some modules used
> to do it. Not so much nowadays, but this one might as well
> consistent within itself.
>
> Do you want to fix it or should I?
Please, go ahead.
Thanks.
>
> Thanks.
>
>> Reviewed-by: Mikhail Zaslonko <zaslonko@linux.ibm.com>
>>
>> On 06.12.2020 07:14, Andrew Morton wrote:
>>> From: Randy Dunlap <rdunlap@infradead.org>
>>> Subject: zlib: export S390 symbols for zlib modules
>>>
>>> Fix build errors when ZLIB_INFLATE=m and ZLIB_DEFLATE=m and ZLIB_DFLTCC=y
>>> by exporting the 2 needed symbols in dfltcc_inflate.c.
>>>
>>> Fixes these build errors:
>>>
>>> ERROR: modpost: "dfltcc_inflate" [lib/zlib_inflate/zlib_inflate.ko] undefined!
>>> ERROR: modpost: "dfltcc_can_inflate" [lib/zlib_inflate/zlib_inflate.ko] undefined!
>>>
>>> Link: https://lkml.kernel.org/r/20201123191712.4882-1-rdunlap@infradead.org
>>> Fixes: 126196100063 ("lib/zlib: add s390 hardware support for kernel zlib_inflate")
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
>>> Cc: Mikhail Zaslonko <zaslonko@linux.ibm.com>
>>> Cc: Heiko Carstens <hca@linux.ibm.com>
>>> Cc: Vasily Gorbik <gor@linux.ibm.com>
>>> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
>>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>>> ---
>>>
>>> lib/zlib_dfltcc/dfltcc_inflate.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> --- a/lib/zlib_dfltcc/dfltcc_inflate.c~zlib-export-s390-symbols-for-zlib-modules
>>> +++ a/lib/zlib_dfltcc/dfltcc_inflate.c
>>> @@ -4,6 +4,7 @@
>>> #include "dfltcc_util.h"
>>> #include "dfltcc.h"
>>> #include <asm/setup.h>
>>> +#include <linux/export.h>
>>> #include <linux/zutil.h>
>>>
>>> /*
>>> @@ -29,6 +30,7 @@ int dfltcc_can_inflate(
>>> return is_bit_set(dfltcc_state->af.fns, DFLTCC_XPND) &&
>>> is_bit_set(dfltcc_state->af.fmts, DFLTCC_FMT0);
>>> }
>>> +EXPORT_SYMBOL(dfltcc_can_inflate);
>>>
>>> static int dfltcc_was_inflate_used(
>>> z_streamp strm
>>> @@ -147,3 +149,4 @@ dfltcc_inflate_action dfltcc_inflate(
>>> return (cc == DFLTCC_CC_OP1_TOO_SHORT || cc == DFLTCC_CC_OP2_TOO_SHORT) ?
>>> DFLTCC_INFLATE_BREAK : DFLTCC_INFLATE_CONTINUE;
>>> }
>>> +EXPORT_SYMBOL(dfltcc_inflate);
>>> _
>>>
>
>
next prev parent reply other threads:[~2020-12-08 8:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 6:14 incoming Andrew Morton
2020-12-06 6:14 ` [patch 01/12] zlib: export S390 symbols for zlib modules Andrew Morton
2020-12-07 9:03 ` Zaslonko Mikhail
2020-12-08 0:45 ` Randy Dunlap
2020-12-08 8:19 ` Zaslonko Mikhail [this message]
2020-12-18 22:18 ` Randy Dunlap
2020-12-06 6:14 ` [patch 02/12] coredump: fix core_pattern parse error Andrew Morton
2020-12-06 6:14 ` [patch 03/12] mm: memcg/slab: fix obj_cgroup_charge() return value handling Andrew Morton
2020-12-06 6:14 ` [patch 04/12] mm: list_lru: set shrinker map bit when child nr_items is not zero Andrew Morton
2020-12-06 6:14 ` [patch 05/12] mm/zsmalloc.c: drop ZSMALLOC_PGTABLE_MAPPING Andrew Morton
2020-12-06 6:14 ` [patch 06/12] mm/swapfile: do not sleep with a spin lock held Andrew Morton
2020-12-06 6:14 ` [patch 07/12] mailmap: add two more addresses of Uwe Kleine-König Andrew Morton
2020-12-06 6:15 ` [patch 08/12] tools/testing/selftests/vm: fix build error Andrew Morton
2020-12-06 6:15 ` [patch 09/12] userfaultfd: selftests: fix SIGSEGV if huge mmap fails Andrew Morton
2020-12-06 6:15 ` [patch 10/12] mm/filemap: add static for function __add_to_page_cache_locked Andrew Morton
2020-12-06 6:15 ` [patch 11/12] hugetlb_cgroup: fix offline of hugetlb cgroup with reservations Andrew Morton
2020-12-06 6:15 ` [patch 12/12] mm/mmap.c: fix mmap return value when vma is merged after call_mmap() Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d4cccc2-5e71-d09b-9b1b-03f30427af56@linux.ibm.com \
--to=zaslonko@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mm-commits@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).