From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BA63C433F5 for ; Mon, 7 Feb 2022 14:46:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C5F66B0075; Mon, 7 Feb 2022 09:46:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 84D6A6B0078; Mon, 7 Feb 2022 09:46:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C7F36B007B; Mon, 7 Feb 2022 09:46:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id 56DDB6B0075 for ; Mon, 7 Feb 2022 09:46:01 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 056818249980 for ; Mon, 7 Feb 2022 14:46:01 +0000 (UTC) X-FDA: 79116258522.04.4D13AC0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 937FC2000C for ; Mon, 7 Feb 2022 14:46:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644245160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=goUbMo4pjupJNfgiLpXay7HxZsEBzbQy6nHdnUofwtE=; b=i7mcWJvRWxXa5zWNLviI3xkMCmkf46w1KxM3q2Y58ATTBT9xN8q0wi60YEXMH0y1gGj15U MCq/zX53v1bf+ibsEcJzh2hkaeZ/cDZmQL3GmJYiIy+MUg+ZDt2W2qi36q3/nlBWj2fcCl LvOIduL0sYs76ABQmDsqGOn5sryqWyI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-668-j0ZOVL5uN0iuKXyzzve22g-1; Mon, 07 Feb 2022 09:45:59 -0500 X-MC-Unique: j0ZOVL5uN0iuKXyzzve22g-1 Received: by mail-wr1-f72.google.com with SMTP id o27-20020adfa11b000000b001e3266e90a8so765603wro.18 for ; Mon, 07 Feb 2022 06:45:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=goUbMo4pjupJNfgiLpXay7HxZsEBzbQy6nHdnUofwtE=; b=3t8Pz5cpb+9nthbC48nAKw7cR0g9vIyK8KHtTK3xftPP3XcvN4Ds7yr+YJmcWWLZX5 zyTlYY6n4CwgLkW3arVCsPHt3tS/gPEREYzI0bYb+fs3RPLRHwWAStwjhfqLDkiHvhm5 dzU/LL93iBT3YWMffEAdWedvzpPGtoe3fBoehO7y7GB0iTFOGjEfWja63Ic93IlEneuE 06f9e60evEv8bnDqswrg9POHl38M6q+0QDet/FtUt3zHD7dTue6IYRK6MWiaP1p/ybXT 1UaS8t0RK2pwzqOO67yGU/IBO4RZIeycaZM/rOaWSwRkplR0zf3ysVRQhSoTuYamamHB jNAw== X-Gm-Message-State: AOAM5314Mltlrswn6Y1ib+7QncHvL7O5+toq2Fy7SWBjyEtgLxGGJgLf eE8IGbdFkQ74EF6rdRYViEMskW6wIeG9llhctsRY/ZmHZkgc8lcKEfStksufETa2h61T3MrYwsD f2mwWc8am0M8= X-Received: by 2002:a5d:564a:: with SMTP id j10mr3584884wrw.473.1644245157940; Mon, 07 Feb 2022 06:45:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5CdjL9GsaPE6SSkw6cwOsU8nZRXi8nUiJucgXQJ5gYIfBfGTfnsdMKLHfFj68uvft/N/gMQ== X-Received: by 2002:a5d:564a:: with SMTP id j10mr3584873wrw.473.1644245157765; Mon, 07 Feb 2022 06:45:57 -0800 (PST) Received: from ?IPV6:2003:cb:c709:6300:a751:d742:1f76:8639? (p200300cbc7096300a751d7421f768639.dip0.t-ipconnect.de. [2003:cb:c709:6300:a751:d742:1f76:8639]) by smtp.gmail.com with ESMTPSA id r2sm1848405wrt.65.2022.02.07.06.45.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Feb 2022 06:45:57 -0800 (PST) Message-ID: <1dd210fa-ac44-6da3-d128-add35fba468e@redhat.com> Date: Mon, 7 Feb 2022 15:45:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 4/4] mm/memory_hotplug: fix misplaced comment in offline_pages To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220207133643.23427-1-linmiaohe@huawei.com> <20220207133643.23427-5-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220207133643.23427-5-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: xqogrzr7nkciiyq789o6nboykbusqgoe X-Rspam-User: nil Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i7mcWJvR; spf=none (imf13.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 937FC2000C X-HE-Tag: 1644245160-442981 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.02.22 14:36, Miaohe Lin wrote: > It's misplaced since commit 7960509329c2 ("mm, memory_hotplug: print reason > for the offlining failure"). Move it to the right place. > > Signed-off-by: Miaohe Lin > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 4b9eef861ee4..7dc7e12302db 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1966,6 +1966,7 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages, > return 0; > > failed_removal_isolated: > + /* pushback to free area */ > undo_isolate_page_range(start_pfn, end_pfn, MIGRATE_MOVABLE); > memory_notify(MEM_CANCEL_OFFLINE, &arg); > failed_removal_pcplists_disabled: > @@ -1976,7 +1977,6 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages, > (unsigned long long) start_pfn << PAGE_SHIFT, > ((unsigned long long) end_pfn << PAGE_SHIFT) - 1, > reason); > - /* pushback to free area */ > mem_hotplug_done(); > return ret; > } Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb