From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DF8AC4338F for ; Wed, 11 Aug 2021 10:32:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E446660D07 for ; Wed, 11 Aug 2021 10:32:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E446660D07 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 463CB6B0071; Wed, 11 Aug 2021 06:32:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 413366B0072; Wed, 11 Aug 2021 06:32:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 301928D0001; Wed, 11 Aug 2021 06:32:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 13BFC6B0071 for ; Wed, 11 Aug 2021 06:32:48 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9D9DC8249980 for ; Wed, 11 Aug 2021 10:32:47 +0000 (UTC) X-FDA: 78462436374.08.AEAF608 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf05.hostedemail.com (Postfix) with ESMTP id 223975023DE2 for ; Wed, 11 Aug 2021 10:32:46 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E1ED1221D1; Wed, 11 Aug 2021 10:32:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628677965; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h0IOg7NR69YsOCPb2F2+XbGSCne9GswMDQ6Ct/w6xk0=; b=arNPy9+c9zlxKrC9LXa0fOXS2sQDJzCp4BoJgWZUBkfFO/9rtgdaI9AMh+9R2blC/3uAb/ QrOxXZ29/Jf67CbQ+6LWDR8iRBWf+g6dqZRdyMiqByVrHEE8RV/Pg0q2U/OMB3Kdm3G++2 IVUYQ07Y7mAvV0ofM9qGEDyUupaOFv8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628677965; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h0IOg7NR69YsOCPb2F2+XbGSCne9GswMDQ6Ct/w6xk0=; b=VrjbUvhxHK82obxp+Y+Sq9yhmbTdVvXLf12WqiCQH2wlo8kJjryDqpvjwS3evruf3bZfDG Ww9ApOH6BXC1/6CQ== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id C03A0131F5; Wed, 11 Aug 2021 10:32:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id 6QVELk2nE2FREAAAGKfGzw (envelope-from ); Wed, 11 Aug 2021 10:32:45 +0000 Subject: Re: [PATCH v14 038/138] mm/memcg: Add folio_memcg() and related functions To: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-39-willy@infradead.org> From: Vlastimil Babka Message-ID: <1eb08e30-3a84-eaae-e9ee-07d59cbde807@suse.cz> Date: Wed, 11 Aug 2021 12:32:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210715033704.692967-39-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 223975023DE2 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=arNPy9+c; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VrjbUvhx; dmarc=none; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Stat-Signature: ehy1ft7djwnn4scm9snyaer3z3pfg3hn X-HE-Tag: 1628677966-504089 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote: > memcg information is only stored in the head page, so the memcg > subsystem needs to assure that all accesses are to the head page. > The first step is converting page_memcg() to folio_memcg(). > > The callers of page_memcg() and PageMemcgKmem() are not yet ready to be > converted to use folios, so retain them as wrappers around folio_memcg() > and folio_memcg_kmem(). They will be converted in a later patch set. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Acked-by: Vlastimil Babka Nit: > --- > include/linux/memcontrol.h | 109 ++++++++++++++++++++++--------------- > mm/memcontrol.c | 21 ++++--- > 2 files changed, 77 insertions(+), 53 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index bfe5c486f4ad..eabae5874161 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -372,6 +372,7 @@ enum page_memcg_data_flags { > #define MEMCG_DATA_FLAGS_MASK (__NR_MEMCG_DATA_FLAGS - 1) > > static inline bool PageMemcgKmem(struct page *page); I think this fwd declaration is no longer needed. > +static inline bool folio_memcg_kmem(struct folio *folio); >