From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <npiggin@suse.de>
Cc: benh@kernel.crashing.org, Paul.McKenney@us.ibm.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch 0/3] 2.6.17 radix-tree: updates and lockless
Date: Tue, 20 Jun 2006 15:35:55 -0700 [thread overview]
Message-ID: <20060620153555.0bd61e7b.akpm@osdl.org> (raw)
In-Reply-To: <20060408134635.22479.79269.sendpatchset@linux.site>
Nick Piggin <npiggin@suse.de> wrote:
>
> I've finally ported the RCU radix tree over my radix tree direct-data patch
> (the latter patch has been in -mm for a while now).
Yes, radix-tree-direct-data.patch and radix-tree-small.patch are for-2.6.18.
> I've also done the last step required for submission, which was to make a
> small userspace RCU test harness, and wire up the rtth so that it can handle
> multiple threads to test the lockless capability. The RCU test harness uses
> an implementation somewhat like Paul's paper's quiescent state bitmask
> approach; with infrequent quiescent state updates, performance isn't bad.
>
> This quickly flushed out several obscure bugs just when running on my dual
> G5. After fixing those, I racked up about 100 CPU hours of testing on
> SUSE's 64-way Altix without problem. Also passes the normal battery of
> single threaded rtth tests.
>
> I'd like to hear views regarding merging these patches for 2.6.18. Initially
> the lockless code would not come into effect (good - one thing at a time)
> until tree_lock can start getting lifted in -mm and 2.6.19.
For 2.6.18 we obviously need to fix the tree_lock box-killer as #1
priority. And whatever we do there needs to be backportable to 2.6.17.
Depending upon Dave's testing results that'll be either covert-to-spinlock
or disable-rwlock-debugging-if-CONFIG_DEBUG_SPINLOCK. Or something else.
We'll see.
So given those complexities, and the lack of a _user_ of
radix-tree-rcu-lockless-readside.patch, it doesn't look like 2.6.18 stuff
at this time.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-06-20 22:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 14:48 [patch 0/3] 2.6.17 radix-tree: updates and lockless Nick Piggin
2006-06-20 14:48 ` [patch 1/3] radix-tree: direct data Nick Piggin
2006-06-20 14:48 ` [patch 2/3] radix-tree: small Nick Piggin
2006-06-20 14:48 ` [patch 3/3] radix-tree: RCU lockless readside Nick Piggin
2006-06-22 1:49 ` Paul E. McKenney
2006-06-22 15:45 ` Nick Piggin
2006-06-22 16:30 ` Paul E. McKenney
2006-06-22 16:55 ` Nick Piggin
2006-06-22 17:40 ` Paul E. McKenney
2006-06-22 18:11 ` Nick Piggin
2006-06-23 7:09 ` Andrew Morton
2006-06-23 8:03 ` Nick Piggin
2006-06-23 8:39 ` Nick Piggin
2006-06-23 8:41 ` Nick Piggin
2006-06-20 22:08 ` [patch 0/3] 2.6.17 radix-tree: updates and lockless Benjamin Herrenschmidt
2006-06-20 22:35 ` Andrew Morton [this message]
2006-06-20 23:09 ` Benjamin Herrenschmidt
2006-06-20 23:30 ` Andrew Morton
2006-06-20 23:50 ` Benjamin Herrenschmidt
2006-06-21 0:34 ` Christoph Lameter
2006-06-21 0:47 ` Benjamin Herrenschmidt
2006-06-21 1:07 ` Christoph Lameter
2006-06-21 1:33 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060620153555.0bd61e7b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Paul.McKenney@us.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).