From: Peter Zijlstra <peterz@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Eric B Munson <emunson@akamai.com>,
Vlastimil Babka <vbabka@suse.cz>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Lameter <cl@linux.com>, Mel Gorman <mgorman@suse.de>,
David Rientjes <rientjes@google.com>,
Rik van Riel <riel@redhat.com>, Michal Hocko <mhocko@suse.cz>,
linux-doc@vger.kernel.org, linux-rt-users@vger.kernel.org,
linux-mm@kvack.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V7] Allow compaction of unevictable pages
Date: Sat, 21 Mar 2015 14:33:11 +0100 [thread overview]
Message-ID: <20150321133311.GA23123@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150320151703.dfd116931ddb397ade8bfd8c@linux-foundation.org>
On Fri, Mar 20, 2015 at 03:17:03PM -0700, Andrew Morton wrote:
> On Fri, 20 Mar 2015 09:49:50 -0400 Eric B Munson <emunson@akamai.com> wrote:
>
> > Currently, pages which are marked as unevictable are protected from
> > compaction, but not from other types of migration. The POSIX real time
> > extension explicitly states that mlock() will prevent a major page
> > fault, but the spirit of this is that mlock() should give a process the
> > ability to control sources of latency, including minor page faults.
> > However, the mlock manpage only explicitly says that a locked page will
> > not be written to swap and this can cause some confusion. The
> > compaction code today does not give a developer who wants to avoid swap
> > but wants to have large contiguous areas available any method to achieve
> > this state. This patch introduces a sysctl for controlling compaction
> > behavior with respect to the unevictable lru. Users that demand no page
> > faults after a page is present can set compact_unevictable_allowed to 0
> > and users who need the large contiguous areas can enable compaction on
> > locked memory by leaving the default value of 1.
>
> Do we really really really need the /proc knob? We're already
> migrating these pages so users of mlock will occasionally see some
> latency - how likely is it that this patch will significantly damage
> anyone?
-rt disables everything that causes those migrations (with exception of
sys_migrate_pages).
And like I've argued before; mlock() is part of the posix real-time
extensions and the real-time people really do not want those migrations.
And while the letter of the posix spec allows migrations, the spirit
clearly does not.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-03-21 13:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 13:49 [PATCH V7] Allow compaction of unevictable pages Eric B Munson
2015-03-20 14:47 ` Rik van Riel
2015-03-20 22:17 ` Andrew Morton
2015-03-21 13:33 ` Peter Zijlstra [this message]
2015-03-20 22:19 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150321133311.GA23123@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=emunson@akamai.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).