From: Borislav Petkov <bp@alien8.de>
To: Toshi Kani <toshi.kani@hp.com>
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
akpm@linux-foundation.org, arnd@arndb.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-nvdimm@lists.01.org, jgross@suse.com,
stefan.bader@canonical.com, luto@amacapital.net, hmh@hmh.eng.br,
yigal@plexistor.com, konrad.wilk@oracle.com, Elliott@hp.com,
mcgrof@suse.com, hch@lst.de
Subject: Re: [PATCH v10 11/12] x86, mm, pat: Refactor !pat_enabled handling
Date: Fri, 29 May 2015 17:13:08 +0200 [thread overview]
Message-ID: <20150529151308.GG31435@pd.tnic> (raw)
In-Reply-To: <1432909628.23540.40.camel@misato.fc.hp.com>
On Fri, May 29, 2015 at 08:27:08AM -0600, Toshi Kani wrote:
> This simply preserves the original error check in the code. This error
> check makes sure that all CPUs have the PAT feature supported when PAT
> is enabled. This error can only happen when heterogeneous CPUs are
> installed/emulated on the system/guest. This check may be paranoid, but
> this cleanup is not meant to modify such an error check.
No, this is a ridiculous attempt to justify crazy code. Please do it
right. If the cleanup makes the code more insane than it is, then don't
do it in the first place.
> Can you consider the patch 10/12-11/12 as a separate patchset from the
> WT series? If that is OK, I will resubmit 10/12 (BUG->panic) and 11/12
> (commit log update).
That's not enough. 11/12 is a convoluted mess which needs splitting and
more detailed explanations in the commit messages.
So no. Read what I said: do the cleanup *first* , *then* add the new
functionality.
The WT patches shouldn't change all too much from what you have now.
Also, 11/12 changes stuff which you add in 1/12. This churn is useless
and shouldn't be there at all.
So you should be able to do the cleanup first and have the WT stuff
ontop just fine.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-05-29 15:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 15:18 [PATCH v10 0/12] Support Write-Through mapping on x86 Toshi Kani
2015-05-27 15:18 ` [PATCH v10 1/12] x86, mm, pat: Set WT to PA7 slot of PAT MSR Toshi Kani
2015-05-27 15:18 ` [PATCH v10 2/12] x86, mm, pat: Change reserve_memtype() for WT Toshi Kani
2015-05-27 15:18 ` [PATCH v10 3/12] x86, asm: Change is_new_memtype_allowed() " Toshi Kani
2015-05-27 15:18 ` [PATCH v10 4/12] x86, mm, asm-gen: Add ioremap_wt() " Toshi Kani
2015-05-27 15:18 ` [PATCH v10 5/12] arch/*/asm/io.h: Add ioremap_wt() to all architectures Toshi Kani
2015-05-27 15:18 ` [PATCH v10 6/12] video/fbdev, asm/io.h: Remove ioremap_writethrough() Toshi Kani
2015-05-27 15:18 ` [PATCH v10 7/12] x86, mm, pat: Add pgprot_writethrough() for WT Toshi Kani
2015-05-27 15:19 ` [PATCH v10 8/12] x86, mm, asm: Add WT support to set_page_memtype() Toshi Kani
2015-05-27 15:19 ` [PATCH v10 9/12] x86, mm: Add set_memory_wt() for WT Toshi Kani
2015-05-27 15:19 ` [PATCH v10 10/12] x86, mm, pat: Cleanup init flags in pat_init() Toshi Kani
2015-05-29 8:59 ` Borislav Petkov
2015-05-27 15:19 ` [PATCH v10 11/12] x86, mm, pat: Refactor !pat_enabled handling Toshi Kani
2015-05-29 8:58 ` Borislav Petkov
2015-05-29 14:27 ` Toshi Kani
2015-05-29 15:13 ` Borislav Petkov [this message]
2015-05-29 15:17 ` Toshi Kani
2015-05-27 15:19 ` [PATCH v10 12/12] drivers/block/pmem: Map NVDIMM with ioremap_wt() Toshi Kani
2015-05-29 9:11 ` Borislav Petkov
2015-05-29 14:43 ` Dan Williams
2015-05-29 15:03 ` Toshi Kani
2015-05-29 18:19 ` Dan Williams
2015-05-29 18:32 ` Toshi Kani
2015-05-29 19:34 ` Dan Williams
2015-05-29 20:10 ` Toshi Kani
2015-05-29 18:34 ` Andy Lutomirski
2015-05-29 19:32 ` Dan Williams
2015-05-29 21:29 ` Elliott, Robert (Server Storage)
2015-05-29 21:46 ` Andy Lutomirski
2015-05-29 22:24 ` Elliott, Robert (Server Storage)
2015-05-29 22:32 ` H. Peter Anvin
2015-06-01 8:58 ` Ingo Molnar
2015-06-01 17:10 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529151308.GG31435@pd.tnic \
--to=bp@alien8.de \
--cc=Elliott@hp.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=hch@lst.de \
--cc=hmh@hmh.eng.br \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=luto@amacapital.net \
--cc=mcgrof@suse.com \
--cc=mingo@redhat.com \
--cc=stefan.bader@canonical.com \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
--cc=yigal@plexistor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).