From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com [209.85.214.178]) by kanga.kvack.org (Postfix) with ESMTP id 757436B0038 for ; Thu, 8 Oct 2015 11:11:51 -0400 (EDT) Received: by obbbh8 with SMTP id bh8so40685666obb.0 for ; Thu, 08 Oct 2015 08:11:51 -0700 (PDT) Received: from foss.arm.com (foss.arm.com. [217.140.101.70]) by mx.google.com with ESMTP id mx9si22536011obb.102.2015.10.08.08.11.50 for ; Thu, 08 Oct 2015 08:11:50 -0700 (PDT) Date: Thu, 8 Oct 2015 16:11:44 +0100 From: Catalin Marinas Subject: Re: [PATCH v6 0/6] KASAN for arm64 Message-ID: <20151008151144.GM17192@e104818-lin.cambridge.arm.com> References: <1442482692-6416-1-git-send-email-ryabinin.a.a@gmail.com> <20151007100411.GG3069@e104818-lin.cambridge.arm.com> <20151008111144.GC7275@leverpostej> <56165228.8060201@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Ard Biesheuvel Cc: Andrey Ryabinin , Mark Rutland , "linux-efi@vger.kernel.org" , Arnd Bergmann , Yury , "linux-mm@kvack.org" , Linus Walleij , Mark Salter , Will Deacon , LKML , Alexey Klimov , Alexander Potapenko , Dmitry Vyukov , Andrey Konovalov , David Keitel , "linux-arm-kernel@lists.infradead.org" On Thu, Oct 08, 2015 at 02:09:26PM +0200, Ard Biesheuvel wrote: > On 8 October 2015 at 13:23, Andrey Ryabinin wrote: > > On 10/08/2015 02:11 PM, Mark Rutland wrote: > >> On Thu, Oct 08, 2015 at 01:36:09PM +0300, Andrey Ryabinin wrote: > >>> 2015-10-07 13:04 GMT+03:00 Catalin Marinas : > >>>> On Thu, Sep 17, 2015 at 12:38:06PM +0300, Andrey Ryabinin wrote: > >>>>> As usual patches available in git > >>>>> git://github.com/aryabinin/linux.git kasan/arm64v6 > >>>>> > >>>>> Changes since v5: > >>>>> - Rebase on top of 4.3-rc1 > >>>>> - Fixed EFI boot. > >>>>> - Updated Doc/features/KASAN. > >>>> > >>>> I tried to merge these patches (apart from the x86 one which is already > >>>> merged) but it still doesn't boot on Juno as an EFI application. > >>>> > >>> > >>> 4.3-rc1 was ok and 4.3-rc4 is not. Break caused by 0ce3cc008ec04 > >>> ("arm64/efi: Fix boot crash by not padding between EFI_MEMORY_RUNTIME > >>> regions") > >>> It introduced sort() call in efi_get_virtmap(). > >>> sort() is generic kernel function and it's instrumented, so we crash > >>> when KASAN tries to access shadow in sort(). > >> > >> I believe this is solved by Ard's stub isolation series [1,2], which > >> will build a stub-specific copy of sort() and various other functions > >> (see the arm-deps in [2]). > >> > >> So long as the stub is not built with ASAN, that should work. > > > > Thanks, this should help, as we already build the stub without ASAN instrumentation. > > Indeed. I did not mention instrumentation in the commit log for those > patches, but obviously, something like KASAN instrumentation cannot be > tolerated in the stub since it makes assumptions about the memory > layout I'll review your latest EFI stub isolation patches and try Kasan again on top (most likely tomorrow). Thanks. -- Catalin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org