From: Catalin Marinas <catalin.marinas@arm.com>
To: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, Yury <yury.norov@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Andrey Konovalov <andreyknvl@google.com>,
Linus Walleij <linus.walleij@linaro.org>,
"Suzuki K. Poulose" <Suzuki.Poulose@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
kasan-dev <kasan-dev@googlegroups.com>,
linux-mm@kvack.org, Alexander Potapenko <glider@google.com>,
Alexey Klimov <klimov.linux@gmail.com>,
David Keitel <dkeitel@codeaurora.org>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH v7 0/4] KASAN for arm64
Date: Wed, 18 Nov 2015 17:24:23 +0000 [thread overview]
Message-ID: <20151118172422.GA5799@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <564C8C47.1080904@gmail.com>
On Wed, Nov 18, 2015 at 05:33:43PM +0300, Andrey Ryabinin wrote:
> On 11/16/2015 07:51 PM, Catalin Marinas wrote:
> > On Mon, Nov 16, 2015 at 06:34:27PM +0300, Andrey Ryabinin wrote:
> >> On 11/16/2015 02:16 PM, Suzuki K. Poulose wrote:
> >>> arch/arm64/mm/kasan_init.c:95:2: note: in expansion of macro a??BUILD_BUG_ONa??
> >>> BUILD_BUG_ON(!IS_ALIGNED(KASAN_SHADOW_END, PGDIR_SIZE));
> >>>
> >>> The problem is that the PGDIR_SIZE is (1UL << 47) with 16K+48bit, which makes
> >>> the KASAN_SHADOW_END unaligned(which is aligned to (1UL << (48 - 3)) ). Is the
> >>> alignment really needed ? Thoughts on how best we could fix this ?
> >>
> >> Yes, it's really needed, because some code relies on this (e.g.
> >> clear_pgs() and kasan_init()). But it should be possible to get rid of
> >> this requirement.
> >
> > I don't think clear_pgds() and kasan_init() are the only problems. IIUC,
> > kasan_populate_zero_shadow() also assumes that KASan shadow covers
> > multiple pgds. You need some kind of recursive writing which avoids
> > populating an entry which is not empty (like kasan_early_pud_populate).
>
> I think kasan_populate_zero_shadow() should be fine. We call pgd_populate() only
> if address range covers the entire pgd:
>
> if (IS_ALIGNED(addr, PGDIR_SIZE) && end - addr >= PGDIR_SIZE) {
> ....
> pgd_populate(&init_mm, pgd, kasan_zero_pud);
> ....
>
> and otherwise we check for pgd_none(*pgd):
> if (pgd_none(*pgd)) {
> pgd_populate(&init_mm, pgd,
> early_alloc(PAGE_SIZE, NUMA_NO_NODE));
> }
OK, I missed the fact that zero_pud_populate() handles the pmd/pte
population with kasan_zero_*.
So if it's only tmp_pg_dir, as you said already, you can add a tmp_pud
for the case where KASAN_SHADOW_SIZE is smaller than PGDIR_SIZE and
change clear_pgds() to erase the puds.
--
Catalin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-18 17:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 15:52 [PATCH v7 0/4] KASAN for arm64 Andrey Ryabinin
2015-10-12 15:52 ` [PATCH v7 1/4] arm64: move PGD_SIZE definition to pgalloc.h Andrey Ryabinin
2015-10-12 15:52 ` [PATCH v7 2/4] arm64: add KASAN support Andrey Ryabinin
2015-10-12 15:52 ` [PATCH v7 3/4] ARM64: kasan: print memory assignment Andrey Ryabinin
2015-10-12 15:53 ` [PATCH v7 4/4] Documentation/features/KASAN: arm64 supports KASAN now Andrey Ryabinin
2015-10-13 8:34 ` [PATCH v7 0/4] KASAN for arm64 Catalin Marinas
2015-11-16 11:16 ` Suzuki K. Poulose
2015-11-16 15:34 ` Andrey Ryabinin
2015-11-16 16:51 ` Catalin Marinas
2015-11-18 14:33 ` Andrey Ryabinin
2015-11-18 15:48 ` Suzuki K. Poulose
2015-11-18 15:52 ` Ard Biesheuvel
2015-11-18 17:24 ` Catalin Marinas [this message]
2015-11-17 14:58 ` Suzuki K. Poulose
2015-11-17 15:47 ` Andrey Ryabinin
2015-11-26 12:10 ` Mark Rutland
2015-11-26 12:22 ` Andrey Ryabinin
2015-11-26 15:05 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118172422.GA5799@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=Suzuki.Poulose@arm.com \
--cc=andreyknvl@google.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=dkeitel@codeaurora.org \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=klimov.linux@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryabinin.a.a@gmail.com \
--cc=will.deacon@arm.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).