From: Andrew Morton <akpm@linux-foundation.org>
To: guillermo.julian@naudit.es
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] mm: fix overflow in vm_map_ram
Date: Fri, 27 May 2016 13:20:35 -0700 [thread overview]
Message-ID: <20160527132035.0239af56b4887e89e7c3b962@linux-foundation.org> (raw)
In-Reply-To: <08d280dc9c9fe037805e3ff74d7dad02@naudit.es>
On Fri, 27 May 2016 10:25:59 +0200 "guillermo.julian" <guillermo.julian@naudit.es> wrote:
> El 2016-05-26 23:28, Andrew Morton escribi__:
> > On Wed, 20 Apr 2016 12:53:33 +0200 Guillermo Juli__n Moreno
> > <guillermo.julian@naudit.es> wrote:
> >
> >>
> >> When remapping pages accounting for 4G or more memory space, the
> >> operation 'count << PAGE_SHIFT' overflows as it is performed on an
> >> integer. Solution: cast before doing the bitshift.
> >
> > Yup.
> >
> > We need to work out which kernel versions to fix. What are the runtime
> > effects of this? Are there real drivers in the tree which actually map
> > more than 4G?
>
> Looking at the references of vm_map_ram, it is only used in three
> drivers (XFS, v4l2-core and android/ion). However, in the vmap() code,
> the same bug is likely to occur (vmalloc.c:1557), and that function is
> more frequently used. But if it has gone unnoticed until now, most
> probably it isn't a critical issue (4G memory allocations are usually
> not needed. In fact this bug surfaced during a performance test in a
> modified driver, not in a regular configuration.
Yup. I'll add this as well:
From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm-fix-overflow-in-vm_map_ram-fix
fix vmap() as well, per Guillermo
Cc: Guillermo Juli_n Moreno <guillermo.julian@naudit.es>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/vmalloc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff -puN mm/vmalloc.c~mm-fix-overflow-in-vm_map_ram-fix mm/vmalloc.c
--- a/mm/vmalloc.c~mm-fix-overflow-in-vm_map_ram-fix
+++ a/mm/vmalloc.c
@@ -1574,14 +1574,15 @@ void *vmap(struct page **pages, unsigned
unsigned long flags, pgprot_t prot)
{
struct vm_struct *area;
+ unsigned long size; /* In bytes */
might_sleep();
if (count > totalram_pages)
return NULL;
- area = get_vm_area_caller((count << PAGE_SHIFT), flags,
- __builtin_return_address(0));
+ size = (unsigned long)count << PAGE_SHIFT;
+ area = get_vm_area_caller(size, flags, __builtin_return_address(0));
if (!area)
return NULL;
_
I checked all other instances of "<< PAGE" in vmalloc.c and we're good.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-05-27 20:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 10:53 [PATCH] mm: fix overflow in vm_map_ram Guillermo Julián Moreno
2016-05-26 7:38 ` Guillermo Julián Moreno
2016-05-26 21:28 ` Andrew Morton
2016-05-27 8:25 ` guillermo.julian
2016-05-27 20:20 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527132035.0239af56b4887e89e7c3b962@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=guillermo.julian@naudit.es \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).