Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] zsmalloc: zspage sanity check
@ 2016-06-03  1:01 Minchan Kim
  0 siblings, 0 replies; only message in thread
From: Minchan Kim @ 2016-06-03  1:01 UTC (permalink / raw)
  To: Vlastimil Babka; +Cc: Andrew Morton, linux-mm, linux-kernel, Sergey Senozhatsky

On Thu, Jun 02, 2016 at 09:25:19AM +0900, Minchan Kim wrote:
> On Wed, Jun 01, 2016 at 04:09:26PM +0200, Vlastimil Babka wrote:
> > On 06/01/2016 01:21 AM, Minchan Kim wrote:
> > 
> > [...]
> > 
> > > 
> > > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > > Signed-off-by: Minchan Kim <minchan@kernel.org>
> > 
> > I'm not that familiar with zsmalloc, so this is not a full review. I was
> > just curious how it's handling the movable migration API, and stumbled
> > upon some things pointed out below.
> > 
> > > @@ -252,16 +276,23 @@ struct zs_pool {
> > >   */
> > >  #define FULLNESS_BITS	2
> > >  #define CLASS_BITS	8
> > > +#define ISOLATED_BITS	3
> > > +#define MAGIC_VAL_BITS	8
> > >  
> > >  struct zspage {
> > >  	struct {
> > >  		unsigned int fullness:FULLNESS_BITS;
> > >  		unsigned int class:CLASS_BITS;
> > > +		unsigned int isolated:ISOLATED_BITS;
> > > +		unsigned int magic:MAGIC_VAL_BITS;
> > 
> > This magic seems to be only tested via VM_BUG_ON, so it's presence
> > should be also guarded by #ifdef DEBUG_VM, no?
> 
> Thanks for the point.
> 
> Then, I want to change it to BUG_ON because struct zspage corruption
> is really risky to work rightly and want to catch on it in real product
> which disable CONFIG_DEBUG_VM for a while until make the feature stable.

Andrew,

Please fold this patch into zsmalloc: page migration support.
Thanks!

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-03  1:01 [PATCH] zsmalloc: zspage sanity check Minchan Kim

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git