From: Andrew Morton <akpm@linux-foundation.org>
To: zhouxianrong@huawei.com
Cc: linux-mm@kvack.org, hughd@google.com, aarcange@redhat.com,
kirill.shutemov@linux.intel.com, dave.hansen@linux.intel.com,
zhouchengming1@huawei.com, geliangtang@163.com,
linux-kernel@vger.kernel.org, zhouxiyu@huawei.com,
wanghaijun5@huawei.com
Subject: Re: [PATCH] ksm: set anon_vma of first rmap_item of ksm page to page's anon_vma other than vma's anon_vma
Date: Thu, 23 Jun 2016 16:49:31 -0700 [thread overview]
Message-ID: <20160623164931.da352f7e6f4b115aba13f37e@linux-foundation.org> (raw)
In-Reply-To: <1466688834-127613-1-git-send-email-zhouxianrong@huawei.com>
On Thu, 23 Jun 2016 21:33:54 +0800 <zhouxianrong@huawei.com> wrote:
> From: z00281421 <z00281421@notesmail.huawei.com>
>
> set anon_vma of first rmap_item of ksm page to page's anon_vma
> other than vma's anon_vma so that we can lookup all the forked
> vma of kpage via reserve map. thus we can try_to_unmap ksm page
> completely and reclaim or migrate the ksm page successfully and
> need not to merg other forked vma addresses of ksm page with
> building a rmap_item for it ever after.
>
> a forked more mapcount ksm page with partially merged vma addresses and
> a ksm page mapped into non-VM_MERGEABLE vma due to setting MADV_MERGEABLE
> on one of the forked vma can be unmapped completely by try_to_unmap.
>
hm, OK, so this is an efficiency increase rather than a functional
change?
If so, are you able to quantify the benefit? ie, how much faster did
things get?
I'll queue it up and shall await Hugh review (please).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-06-23 23:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 13:33 [PATCH] ksm: set anon_vma of first rmap_item of ksm page to page's anon_vma other than vma's anon_vma zhouxianrong
2016-06-23 23:49 ` Andrew Morton [this message]
2016-07-20 0:42 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623164931.da352f7e6f4b115aba13f37e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=geliangtang@163.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wanghaijun5@huawei.com \
--cc=zhouchengming1@huawei.com \
--cc=zhouxianrong@huawei.com \
--cc=zhouxiyu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).