From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id 6F3D46B0005 for ; Mon, 18 Jul 2016 12:11:40 -0400 (EDT) Received: by mail-wm0-f69.google.com with SMTP id o80so61917027wme.1 for ; Mon, 18 Jul 2016 09:11:40 -0700 (PDT) Received: from gum.cmpxchg.org (gum.cmpxchg.org. [85.214.110.215]) by mx.google.com with ESMTPS id c66si15594722wmi.58.2016.07.18.09.11.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jul 2016 09:11:39 -0700 (PDT) Date: Mon, 18 Jul 2016 12:11:28 -0400 From: Johannes Weiner Subject: Re: [PATCH 1/3] mm, vmscan: Remove redundant check in shrink_zones() Message-ID: <20160718161128.GA16465@cmpxchg.org> References: <1468853426-12858-1-git-send-email-mgorman@techsingularity.net> <1468853426-12858-2-git-send-email-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468853426-12858-2-git-send-email-mgorman@techsingularity.net> Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Andrew Morton , Minchan Kim , Vlastimil Babka , Linux-MM , LKML On Mon, Jul 18, 2016 at 03:50:24PM +0100, Mel Gorman wrote: > As pointed out by Minchan Kim, shrink_zones() checks for populated > zones in a zonelist but a zonelist can never contain unpopulated > zones. While it's not related to the node-lru series, it can be > cleaned up now. > > Suggested-by: Minchan Kim > Signed-off-by: Mel Gorman Ha, I didn't know that. But yeah, the zonelist building code excludes unpopulated zones from the start. Neat. Acked-by: Johannes Weiner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org