From: Michal Hocko <mhocko@suse.cz>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, oleg@redhat.com,
vdavydov@virtuozzo.com, rientjes@google.com
Subject: Re: [PATCH] mm, oom: fix for hiding mm which is shared with kthread or global init
Date: Tue, 19 Jul 2016 13:58:02 +0200 [thread overview]
Message-ID: <20160719115801.GH9486@dhcp22.suse.cz> (raw)
In-Reply-To: <201607192043.CEI28519.VtQOMFFSFLOJOH@I-love.SAKURA.ne.jp>
On Tue 19-07-16 20:43:32, Tetsuo Handa wrote:
> Michal Hocko wrote:
> > On Tue 19-07-16 19:36:40, Tetsuo Handa wrote:
> > > Michal Hocko wrote:
[...]
> > > > And that being said. If you strongly disagree with the wording then what
> > > > about the following:
> > > > "
> > > > In order to help a forward progress for the OOM killer, make sure that
> > > > this really rare cases will not get into the way and hide the mm from the
> > > > oom killer by setting MMF_OOM_REAPED flag for it. oom_scan_process_thread
> > > > will ignore any TIF_MEMDIE task if it has MMF_OOM_REAPED flag set to catch
> > > > these oom victims.
> > > >
> > > > After this patch we should guarantee a forward progress for the OOM killer
> > > > even when the selected victim is sharing memory with a kernel thread or
> > > > global init as long as the victims mm is still alive.
> > > > "
> > >
> > > No, I don't like "as long as the victims mm is still alive" exception.
> >
> > Why? Because of the wording or in principle?
>
> Making a _guarantee without exceptions now_ can allow other OOM livelock handlings
I am not convinced this particular thing would be the last piece in the
puzzle... And as already said before. Can we wait for the merge window
with the next changes please? I really do not want end up in a situation
where we would have too many oom fixes in flight again. There is no
reason to hurry.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-07-19 11:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 5:30 [PATCH] mm, oom: fix for hiding mm which is shared with kthread or global init Tetsuo Handa
2016-07-18 7:18 ` Michal Hocko
2016-07-18 21:30 ` [PATCH] mm, oom: fix for hiding mm which is shared with kthreador " Tetsuo Handa
2016-07-19 6:40 ` Michal Hocko
2016-07-19 9:37 ` Michal Hocko
2016-07-19 10:36 ` [PATCH] mm, oom: fix for hiding mm which is shared with kthread or " Tetsuo Handa
2016-07-19 10:54 ` Michal Hocko
2016-07-19 11:43 ` Tetsuo Handa
2016-07-19 11:58 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719115801.GH9486@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).