Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2] numa node stats alternative fix
@ 2017-01-02 15:30 Michal Hocko
  2017-01-02 15:30 ` [PATCH 1/2] mm: fix remote numa hits statistics Michal Hocko
  2017-01-02 15:30 ` [PATCH 2/2] mm: get rid of __GFP_OTHER_NODE Michal Hocko
  0 siblings, 2 replies; 9+ messages in thread
From: Michal Hocko @ 2017-01-02 15:30 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Mel Gorman, Vlastimil Babka, Jia He, Andi Kleen, linux-mm, LKML

Hi,
this is an alternative fix for [1] which is currently sitting in the mm
tree.  I believe that the patch 1 is better because it allows to get rid
of __GFP_OTHER_NODE (patch 2) and it uses less branches as well. Vlastimil
has also shown [2] that the patch from Jia He is not fully compatible with
the code before the patch it tries to fix. I do not think that the issue
is serious enough to warrant stable tree inclusion.

Can we have these patches merged instead?

[1] http://lkml.kernel.org/r/1481522347-20393-1-git-send-email-hejianet@gmail.com
[2] http://lkml.kernel.org/r/233ed490-afb9-4644-6d84-c9f888882da2@suse.cz

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data
@ 2016-12-21  7:57 Michal Hocko
  2016-12-21  8:06 ` [PATCH 1/2] mm: fix remote numa hits statistics Michal Hocko
  0 siblings, 1 reply; 9+ messages in thread
From: Michal Hocko @ 2016-12-21  7:57 UTC (permalink / raw)
  To: Mel Gorman
  Cc: Jia He, linux-mm, linux-kernel, Andrew Morton, Vlastimil Babka,
	Johannes Weiner, Joonsoo Kim, Taku Izumi

On Tue 20-12-16 14:54:35, Mel Gorman wrote:
> On Tue, Dec 20, 2016 at 03:35:02PM +0100, Michal Hocko wrote:
> > On Tue 20-12-16 14:28:45, Mel Gorman wrote:
> > > On Tue, Dec 20, 2016 at 02:26:43PM +0100, Michal Hocko wrote:
> > > > On Tue 20-12-16 13:10:40, Mel Gorman wrote:
> > > > > On Tue, Dec 20, 2016 at 10:18:14AM +0100, Michal Hocko wrote:
> > > > > > On Mon 12-12-16 13:59:07, Jia He wrote:
> > > > > > > In commit b9f00e147f27 ("mm, page_alloc: reduce branches in
> > > > > > > zone_statistics"), it reconstructed codes to reduce the branch miss rate.
> > > > > > > Compared with the original logic, it assumed if !(flag & __GFP_OTHER_NODE)
> > > > > > >  z->node would not be equal to preferred_zone->node. That seems to be
> > > > > > > incorrect.
> > > > > > 
> > > > > > I am sorry but I have hard time following the changelog. It is clear
> > > > > > that you are trying to fix a missed NUMA_{HIT,OTHER} accounting
> > > > > > but it is not really clear when such thing happens. You are adding
> > > > > > preferred_zone->node check. preferred_zone is the first zone in the
> > > > > > requested zonelist. So for the most allocations it is a node from the
> > > > > > local node. But if something request an explicit numa node (without
> > > > > > __GFP_OTHER_NODE which would be the majority I suspect) then we could
> > > > > > indeed end up accounting that as a NUMA_MISS, NUMA_FOREIGN so the
> > > > > > referenced patch indeed caused an unintended change of accounting AFAIU.
> > > > > > 
> > > > > 
> > > > > This is a similar concern to what I had. If the preferred zone, which is
> > > > > the first valid usable zone, is not a "hit" for the statistics then I
> > > > > don't know what "hit" is meant to mean.
> > > > 
> > > > But the first valid usable zone is defined based on the requested numa
> > > > node. Unless the requested node is memoryless then we should have a hit,
> > > > no?
> > > > 
> > > 
> > > Should be. If the local node is memoryless then there would be a difference
> > > between hit and whether it's local or not but that to me is a little
> > > useless. A local vs remote page allocated has a specific meaning and
> > > consequence. It's hard to see how hit can be meaningfully interpreted if
> > > there are memoryless nodes. I don't have a strong objection to the patch
> > > so I didn't nak it, I'm just not convinced it matters.
> > 
> > So what do you think about
> > http://lkml.kernel.org/r/20161220091814.GC3769@dhcp22.suse.cz
> > 
> 
> This doesn't appear to resolve for me and I've 30 minutes left before
> being offline for 4 days so didn't go digging. 

OK, it seems that it didn't go to the lkml so it didn't get to the
archive indexed by the message id. I will send the two patches as a
reply to this email for reference.

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-02 15:30 [PATCH 0/2] numa node stats alternative fix Michal Hocko
2017-01-02 15:30 ` [PATCH 1/2] mm: fix remote numa hits statistics Michal Hocko
2017-01-02 15:30 ` [PATCH 2/2] mm: get rid of __GFP_OTHER_NODE Michal Hocko
  -- strict thread matches above, loose matches on Subject: below --
2016-12-21  7:57 [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data Michal Hocko
2016-12-21  8:06 ` [PATCH 1/2] mm: fix remote numa hits statistics Michal Hocko
2016-12-29 11:46   ` Mel Gorman
2016-12-29 12:28     ` Michal Hocko
2017-01-02 14:16   ` Vlastimil Babka
2017-01-02 14:46     ` Michal Hocko
2017-01-02 15:07       ` Vlastimil Babka

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git