From: Michal Hocko <mhocko@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
kvm@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org,
linux-ext4@vger.kernel.org, Joe Perches <joe@perches.com>,
Anatoly Stepanov <astepanov@cloudlinux.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Theodore Ts'o <tytso@mit.edu>, Andreas Dilger <adilger@dilger.ca>
Subject: Re: [PATCH] mm: introduce kv[mz]alloc helpers
Date: Fri, 6 Jan 2017 14:34:59 +0100 [thread overview]
Message-ID: <20170106133459.GM5556@dhcp22.suse.cz> (raw)
In-Reply-To: <747f7b9a-e95d-a872-7e30-ea235b91593a@suse.cz>
On Fri 06-01-17 14:29:33, Vlastimil Babka wrote:
> On 01/02/2017 02:37 PM, Michal Hocko wrote:
> > --- a/drivers/vhost/vhost.c
> > +++ b/drivers/vhost/vhost.c
> > @@ -514,18 +514,9 @@ long vhost_dev_set_owner(struct vhost_dev *dev)
> > }
> > EXPORT_SYMBOL_GPL(vhost_dev_set_owner);
> >
> > -static void *vhost_kvzalloc(unsigned long size)
> > -{
> > - void *n = kzalloc(size, GFP_KERNEL | __GFP_NOWARN | __GFP_REPEAT);
>
> Hi, I just noticed that this had __GFP_REPEAT, so you'll probably want
> to move these hunks to patch 3 with the rest of vhost.
Well, spotted. I will do that. Thanks!
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-01-06 13:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 13:37 [PATCH] mm: introduce kv[mz]alloc helpers Michal Hocko
2017-01-02 15:55 ` Joe Perches
2017-01-02 16:02 ` Michal Hocko
2017-01-03 10:23 ` Vlastimil Babka
2017-01-03 10:33 ` Michal Hocko
2017-01-04 14:20 ` Michal Hocko
2017-01-05 10:40 ` Tetsuo Handa
2017-01-05 10:59 ` Michal Hocko
2017-01-06 14:54 ` Kent Overstreet
2017-01-06 14:36 ` Vlastimil Babka
2017-01-06 15:10 ` Michal Hocko
2017-01-04 18:12 ` [PATCH] mm: support __GFP_REPEAT in kvmalloc_node Michal Hocko
2017-01-06 12:09 ` Vlastimil Babka
2017-01-06 12:31 ` Michal Hocko
2017-01-09 8:50 ` Michal Hocko
2017-01-06 13:29 ` [PATCH] mm: introduce kv[mz]alloc helpers Vlastimil Babka
2017-01-06 13:34 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170106133459.GM5556@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=adilger@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=astepanov@cloudlinux.com \
--cc=hannes@cmpxchg.org \
--cc=joe@perches.com \
--cc=kvm@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
--cc=snitzer@redhat.com \
--cc=tytso@mit.edu \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).