From: Mel Gorman <mgorman@suse.de>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
David Rientjes <rientjes@google.com>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 4/4] lib/show_mem.c: teach show_mem to work with the given nodemask
Date: Thu, 12 Jan 2017 13:49:42 +0000 [thread overview]
Message-ID: <20170112134942.46d6adcjshfeyj4r@suse.de> (raw)
In-Reply-To: <20170112131659.23058-5-mhocko@kernel.org>
On Thu, Jan 12, 2017 at 02:16:59PM +0100, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> show_mem() allows to filter out node specific data which is irrelevant
> to the allocation request via SHOW_MEM_FILTER_NODES. The filtering
> is done in skip_free_areas_node which skips all nodes which are not
> in the mems_allowed of the current process. This works most of the
> time as expected because the nodemask shouldn't be outside of the
> allocating task but there are some exceptions. E.g. memory hotplug might
> want to request allocations from outside of the allowed nodes (see
> new_node_page).
>
> Get rid of this hardcoded behavior and push the allocation mask down the
> show_mem path and use it instead of cpuset_current_mems_allowed. NULL
> nodemask is interpreted as cpuset_current_mems_allowed.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
Fairly marginal but
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-12 13:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 13:16 [PATCH 0/4] show_mem updates Michal Hocko
2017-01-12 13:16 ` [PATCH 1/4] mm, page_alloc: do not report all nodes in show_mem Michal Hocko
2017-01-12 13:47 ` Mel Gorman
2017-01-14 16:26 ` Johannes Weiner
2017-01-12 13:16 ` [PATCH 2/4] mm, page_alloc: warn_alloc print nodemask Michal Hocko
2017-01-12 13:47 ` Mel Gorman
2017-01-13 11:31 ` Vlastimil Babka
2017-01-13 14:58 ` Michal Hocko
2017-01-12 13:16 ` [RFC PATCH 3/4] arch, mm: remove arch specific show_mem Michal Hocko
2017-01-12 13:48 ` Mel Gorman
2017-01-12 17:53 ` Chris Metcalf
2017-01-12 20:04 ` Helge Deller
2017-01-13 2:49 ` Xuetao Guan
2017-01-14 16:29 ` Johannes Weiner
2017-01-12 13:16 ` [PATCH 4/4] lib/show_mem.c: teach show_mem to work with the given nodemask Michal Hocko
2017-01-12 13:49 ` Mel Gorman [this message]
2017-01-13 13:08 ` Vlastimil Babka
2017-01-13 15:08 ` Michal Hocko
2017-01-13 15:30 ` Vlastimil Babka
2017-01-17 9:15 [PATCH 0/4 v2] show_mem updates Michal Hocko
2017-01-17 9:15 ` [PATCH 4/4] lib/show_mem.c: teach show_mem to work with the given nodemask Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112134942.46d6adcjshfeyj4r@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).