From: Michal Hocko <mhocko@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Nikolay Borisov <nborisov@suse.com>,
linux-kernel@vger.kernel.org, vbabka.lkml@gmail.com,
linux-mm@kvack.org, mingo@redhat.com
Subject: Re: [PATCH v3] lockdep: Teach lockdep about memalloc_noio_save
Date: Wed, 1 Mar 2017 17:05:30 +0100 [thread overview]
Message-ID: <20170301160529.GI11730@dhcp22.suse.cz> (raw)
In-Reply-To: <20170301154659.GL6515@twins.programming.kicks-ass.net>
On Wed 01-03-17 16:46:59, Peter Zijlstra wrote:
> On Wed, Mar 01, 2017 at 01:29:57PM +0200, Nikolay Borisov wrote:
> > Commit 21caf2fc1931 ("mm: teach mm by current context info to not do I/O
> > during memory allocation") added the memalloc_noio_(save|restore) functions
> > to enable people to modify the MM behavior by disbaling I/O during memory
> > allocation. This was further extended in Fixes: 934f3072c17c ("mm: clear
> > __GFP_FS when PF_MEMALLOC_NOIO is set"). memalloc_noio_* functions prevent
> > allocation paths recursing back into the filesystem without explicitly
> > changing the flags for every allocation site. However, lockdep hasn't been
> > keeping up with the changes and it entirely misses handling the memalloc_noio
> > adjustments. Instead, it is left to the callers of __lockdep_trace_alloc to
> > call the functino after they have shaven the respective GFP flags.
> >
> > Let's fix this by making lockdep explicitly do the shaving of respective
> > GFP flags.
>
> I edited that to look like the below, then my compiler said:
>
> ../kernel/locking/lockdep.c: In function a??lockdep_set_current_reclaim_statea??:
> ../kernel/locking/lockdep.c:3866:33: error: implicit declaration of function a??memalloc_noio_flagsa?? [-Werror=implicit-function-declaration]
> current->lockdep_reclaim_gfp = memalloc_noio_flags(gfp_mask);
> ^~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> ../scripts/Makefile.build:294: recipe for target 'kernel/locking/lockdep.o' failed
It did compile for me
$ grep CONFIG_LOCKDEP .config
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_LOCKDEP=y
Anyway, does the following help?
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 47e4f82380e4..d5386ad7ed3f 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -47,6 +47,7 @@
#include <linux/kmemcheck.h>
#include <linux/random.h>
#include <linux/jhash.h>
+#include <linux/sched.h>
#include <asm/sections.h>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-01 16:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 11:29 [PATCH v3] lockdep: Teach lockdep about memalloc_noio_save Nikolay Borisov
2017-03-01 12:09 ` Michal Hocko
2017-03-01 15:46 ` Peter Zijlstra
2017-03-01 16:01 ` Peter Zijlstra
2017-03-01 16:05 ` Michal Hocko [this message]
2017-03-01 16:12 ` Peter Zijlstra
2017-03-01 16:18 ` Michal Hocko
2017-03-03 8:04 ` Michal Hocko
2017-03-03 8:22 ` Peter Zijlstra
2017-03-03 8:31 ` Michal Hocko
2017-03-03 8:37 ` Michal Hocko
2017-03-03 8:50 ` Peter Zijlstra
2017-03-03 6:50 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301160529.GI11730@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=nborisov@suse.com \
--cc=peterz@infradead.org \
--cc=vbabka.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).