From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Xiong Zhou <xzhou@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: mm allocation failure and hang when running xfstests generic/269 on xfs
Date: Thu, 2 Mar 2017 11:35:20 +0100 [thread overview]
Message-ID: <20170302103520.GC1404@dhcp22.suse.cz> (raw)
In-Reply-To: <42eb5d53-5ceb-a9ce-791a-9469af30810c@I-love.SAKURA.ne.jp>
On Thu 02-03-17 19:04:48, Tetsuo Handa wrote:
[...]
> So, commit 5d17a73a2ebeb8d1("vmalloc: back off when the current task is
> killed") implemented __GFP_KILLABLE flag and automatically applied that
> flag. As a result, those who are not ready to fail upon SIGKILL are
> confused. ;-)
You are right! The function is documented it might fail but the code
doesn't really allow that. This seems like a bug to me. What do you
think about the following?
---
next prev parent reply other threads:[~2017-03-02 10:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 4:46 mm allocation failure and hang when running xfstests generic/269 on xfs Xiong Zhou
2017-03-02 0:37 ` Christoph Hellwig
2017-03-02 5:19 ` Xiong Zhou
2017-03-02 6:41 ` Bob Liu
2017-03-02 6:47 ` Anshuman Khandual
2017-03-02 8:42 ` Michal Hocko
2017-03-02 9:23 ` Xiong Zhou
2017-03-02 10:04 ` Tetsuo Handa
2017-03-02 10:35 ` Michal Hocko [this message]
2017-03-02 10:53 ` mm allocation failure and hang when running xfstests generic/269on xfs Tetsuo Handa
2017-03-02 12:24 ` mm allocation failure and hang when running xfstests generic/269 on xfs Brian Foster
2017-03-02 12:49 ` Michal Hocko
2017-03-02 13:00 ` Brian Foster
2017-03-02 13:07 ` Tetsuo Handa
2017-03-02 13:27 ` Michal Hocko
2017-03-02 13:41 ` Brian Foster
2017-03-02 13:50 ` Michal Hocko
2017-03-02 14:23 ` Brian Foster
2017-03-02 14:34 ` Michal Hocko
2017-03-02 14:51 ` Brian Foster
2017-03-02 15:14 ` Michal Hocko
2017-03-02 15:30 ` Brian Foster
2017-03-02 15:45 ` [PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail Michal Hocko
2017-03-02 15:45 ` [PATCH 2/2] xfs: back off from kmem_zalloc_greedy if the task is killed Michal Hocko
2017-03-02 15:49 ` Christoph Hellwig
2017-03-02 15:59 ` Brian Foster
2017-03-02 15:49 ` [PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail Christoph Hellwig
2017-03-02 15:59 ` Brian Foster
2017-03-02 16:16 ` Michal Hocko
2017-03-02 16:44 ` Darrick J. Wong
2017-03-03 22:54 ` Dave Chinner
2017-03-03 23:19 ` Darrick J. Wong
2017-03-04 4:48 ` Dave Chinner
2017-03-06 13:21 ` Michal Hocko
2017-03-02 15:47 ` mm allocation failure and hang when running xfstests generic/269 on xfs Michal Hocko
2017-03-02 15:47 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302103520.GC1404@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).