From: Daniel Vetter <daniel@ffwll.ch>
To: Laura Abbott <labbott@redhat.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
devel@driverdev.osuosl.org, romlem@google.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
arve@android.com, linux-kernel@vger.kernel.org,
linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org,
Riley Andrews <riandrews@android.com>,
Mark Brown <broonie@kernel.org>,
Daniel Vetter <daniel.vetter@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support
Date: Mon, 6 Mar 2017 11:29:59 +0100 [thread overview]
Message-ID: <20170306102959.5iixtstrl7ktwxdp@phenom.ffwll.local> (raw)
In-Reply-To: <87fe5d0a-19d2-b6c7-391f-687aa5ff8571@redhat.com>
On Fri, Mar 03, 2017 at 10:46:03AM -0800, Laura Abbott wrote:
> On 03/03/2017 08:39 AM, Laurent Pinchart wrote:
> > Hi Daniel,
> >
> > On Friday 03 Mar 2017 10:56:54 Daniel Vetter wrote:
> >> On Thu, Mar 02, 2017 at 01:44:38PM -0800, Laura Abbott wrote:
> >>> Now that we call dma_map in the dma_buf API callbacks there is no need
> >>> to use the existing cache APIs. Remove the sync ioctl and the existing
> >>> bad dma_sync calls. Explicit caching can be handled with the dma_buf
> >>> sync API.
> >>>
> >>> Signed-off-by: Laura Abbott <labbott@redhat.com>
> >>> ---
> >>>
> >>> drivers/staging/android/ion/ion-ioctl.c | 5 ----
> >>> drivers/staging/android/ion/ion.c | 40 --------------------
> >>> drivers/staging/android/ion/ion_carveout_heap.c | 6 ----
> >>> drivers/staging/android/ion/ion_chunk_heap.c | 6 ----
> >>> drivers/staging/android/ion/ion_page_pool.c | 3 --
> >>> drivers/staging/android/ion/ion_system_heap.c | 5 ----
> >>> 6 files changed, 65 deletions(-)
> >>>
> >>> diff --git a/drivers/staging/android/ion/ion-ioctl.c
> >>> b/drivers/staging/android/ion/ion-ioctl.c index 5b2e93f..f820d77 100644
> >>> --- a/drivers/staging/android/ion/ion-ioctl.c
> >>> +++ b/drivers/staging/android/ion/ion-ioctl.c
> >>> @@ -146,11 +146,6 @@ long ion_ioctl(struct file *filp, unsigned int cmd,
> >>> unsigned long arg)>
> >>> data.handle.handle = handle->id;
> >>>
> >>> break;
> >>>
> >>> }
> >>>
> >>> - case ION_IOC_SYNC:
> >>> - {
> >>> - ret = ion_sync_for_device(client, data.fd.fd);
> >>> - break;
> >>> - }
> >>
> >> You missed the case ION_IOC_SYNC: in compat_ion.c.
> >>
> >> While at it: Should we also remove the entire custom_ioctl infrastructure?
> >> It's entirely unused afaict, and for a pure buffer allocator I don't see
> >> any need to have custom ioctl.
> >
> > I second that, if you want to make ion a standard API, then we certainly don't
> > want any custom ioctl.
> >
> >> More code to remove potentially:
> >> - The entire compat ioctl stuff - would be an abi break, but I guess if we
> >> pick the 32bit abi and clean up the uapi headers we'll be mostly fine.
> >> would allow us to remove compat_ion.c entirely.
> >>
> >> - ION_IOC_IMPORT: With this ion is purely an allocator, so not sure we
> >> still need to be able to import anything. All the cache flushing/mapping
> >> is done through dma-buf ops/ioctls.
> >>
> >>
>
> Good point to all of the above. I was considering keeping the import around
> for backwards compatibility reasons but given how much other stuff is being
> potentially broken, everything should just get ripped out.
If you're ok with breaking the world, then I strongly suggest we go
through the uapi header and replace all types with the standard
fixed-width ones (__s32, __s64 and __u32, __u64). Allows us to remove all
the compat ioctl code :-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-06 10:30 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 21:44 [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Laura Abbott
2017-03-02 21:44 ` [RFC PATCH 01/12] staging: android: ion: Remove dmap_cnt Laura Abbott
2017-03-02 21:44 ` [RFC PATCH 02/12] staging: android: ion: Remove alignment from allocation field Laura Abbott
2017-03-02 21:44 ` [RFC PATCH 03/12] staging: android: ion: Duplicate sg_table Laura Abbott
2017-03-03 8:18 ` Hillf Danton
2017-03-03 18:41 ` Laura Abbott
2017-03-02 21:44 ` [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for syncing and mapping Laura Abbott
2017-03-03 11:04 ` Dan Carpenter
2017-03-03 11:58 ` Eric Engestrom
2017-03-03 16:37 ` Laurent Pinchart
2017-03-03 18:40 ` Laura Abbott
2017-03-02 21:44 ` [RFC PATCH 05/12] staging: android: ion: Remove page faulting support Laura Abbott
2017-03-02 21:44 ` [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support Laura Abbott
2017-03-03 9:56 ` Daniel Vetter
2017-03-03 16:39 ` Laurent Pinchart
2017-03-03 18:46 ` Laura Abbott
2017-03-06 10:29 ` Daniel Vetter [this message]
2017-03-06 17:00 ` Emil Velikov
2017-03-06 19:20 ` Laura Abbott
2017-03-02 21:44 ` [RFC PATCH 07/12] staging: android: ion: Remove old platform support Laura Abbott
2017-03-03 10:31 ` Daniel Vetter
2017-03-02 21:44 ` [RFC PATCH 08/12] cma: Store a name in the cma structure Laura Abbott
2017-03-10 8:53 ` Sumit Semwal
2017-03-17 18:02 ` Laura Abbott
2017-03-02 21:44 ` [RFC PATCH 09/12] cma: Introduce cma_for_each_area Laura Abbott
2017-03-02 21:44 ` [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly Laura Abbott
2017-03-03 16:41 ` Laurent Pinchart
2017-03-03 18:50 ` Laura Abbott
2017-03-06 10:32 ` Daniel Vetter
2017-03-06 13:43 ` Laurent Pinchart
2017-03-06 15:52 ` Daniel Vetter
2017-03-06 19:14 ` Laura Abbott
2017-03-02 21:44 ` [RFC PATCH 11/12] staging: android: ion: Make Ion heaps selectable Laura Abbott
2017-03-03 10:33 ` Daniel Vetter
2017-03-03 19:10 ` Laura Abbott
2017-03-02 21:44 ` [RFC PATCH 12/12] staging; android: ion: Enumerate all available heaps Laura Abbott
2017-03-03 10:39 ` Daniel Vetter
2017-03-03 10:04 ` [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Daniel Vetter
2017-03-03 10:27 ` Daniel Vetter
2017-03-03 12:54 ` Benjamin Gaignard
2017-03-03 16:45 ` Laurent Pinchart
2017-03-03 19:16 ` Laura Abbott
2017-03-06 10:38 ` Daniel Vetter
2017-03-06 15:02 ` Laurent Pinchart
2017-03-06 16:01 ` Daniel Vetter
2017-03-03 13:29 ` Michal Hocko
2017-03-03 17:37 ` Laura Abbott
2017-03-06 7:42 ` Michal Hocko
2017-03-06 10:40 ` Daniel Vetter
2017-03-06 10:58 ` Mark Brown
2017-03-06 16:04 ` Daniel Vetter
2017-03-09 10:00 ` Benjamin Gaignard
2017-03-09 17:38 ` Laura Abbott
2017-03-10 10:31 ` Brian Starkey
2017-03-10 11:46 ` Robin Murphy
2017-03-10 14:27 ` Brian Starkey
2017-03-10 16:46 ` Laura Abbott
2017-03-10 12:40 ` Daniel Vetter
2017-03-10 13:56 ` Rob Clark
2017-03-12 13:34 ` Benjamin Gaignard
2017-03-12 19:05 ` Daniel Vetter
2017-03-13 21:09 ` Laura Abbott
2017-03-13 21:29 ` Rob Clark
2017-03-13 21:59 ` Laura Abbott
2017-03-14 14:47 ` Benjamin Gaignard
2017-03-14 19:45 ` Laura Abbott
2017-03-14 20:28 ` Nicolas Dufresne
2017-03-13 10:54 ` Brian Starkey
2017-03-13 13:21 ` Mark Brown
2017-03-13 21:45 ` Laura Abbott
2017-03-13 21:29 ` Laura Abbott
2017-03-06 13:34 ` Michal Hocko
2017-03-03 16:25 ` Laurent Pinchart
2017-03-03 19:14 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170306102959.5iixtstrl7ktwxdp@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=arve@android.com \
--cc=broonie@kernel.org \
--cc=daniel.vetter@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=labbott@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riandrews@android.com \
--cc=romlem@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).