From: Michal Hocko <mhocko@kernel.org>
To: Laurent Dufour <ldufour@linux.vnet.ibm.com>,
Andi Kleen <andi@firstfloor.org>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org
Subject: Re: [PATCH v2 1/2] mm: Uncharge poisoned pages
Date: Fri, 28 Apr 2017 08:07:55 +0200 [thread overview]
Message-ID: <20170428060755.GA8143@dhcp22.suse.cz> (raw)
In-Reply-To: <87pofxk20k.fsf@firstfloor.org>
On Thu 27-04-17 13:51:23, Andi Kleen wrote:
> Michal Hocko <mhocko@kernel.org> writes:
>
> > On Tue 25-04-17 16:27:51, Laurent Dufour wrote:
> >> When page are poisoned, they should be uncharged from the root memory
> >> cgroup.
> >>
> >> This is required to avoid a BUG raised when the page is onlined back:
> >> BUG: Bad page state in process mem-on-off-test pfn:7ae3b
> >> page:f000000001eb8ec0 count:0 mapcount:0 mapping: (null)
> >> index:0x1
> >> flags: 0x3ffff800200000(hwpoison)
> >
> > My knowledge of memory poisoning is very rudimentary but aren't those
> > pages supposed to leak and never come back? In other words isn't the
> > hoplug code broken because it should leave them alone?
>
> Yes that would be the right interpretation. If it was really offlined
> due to a hardware error the memory will be poisoned and any access
> could cause a machine check.
OK, thanks for the clarification. Then I am not sure the patch is
correct. Why do we need to uncharge that page at all? It is not freed.
The correct thing to do is to not online it in the first place which is
done in patch2 [1]. Even if we need to uncharge the page the reason is
not to silent the BUG, that is merely papering a issue than a real fix.
Laurent can you elaborate please.
[1] http://lkml.kernel.org/r/1493130472-22843-3-git-send-email-ldufour@linux.vnet.ibm.com
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-04-28 6:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 14:27 [PATCH v2 0/2] BUG raised when onlining HWPoisoned page Laurent Dufour
2017-04-25 14:27 ` [PATCH v2 1/2] mm: Uncharge poisoned pages Laurent Dufour
2017-04-25 23:48 ` Naoya Horiguchi
2017-04-26 1:54 ` Balbir Singh
2017-04-26 2:34 ` Naoya Horiguchi
2017-04-26 3:45 ` Balbir Singh
2017-04-26 4:46 ` Naoya Horiguchi
2017-04-26 8:59 ` Balbir Singh
2017-04-28 9:32 ` Laurent Dufour
2017-04-27 14:37 ` Michal Hocko
2017-04-27 20:51 ` Andi Kleen
2017-04-28 6:07 ` Michal Hocko [this message]
2017-04-28 7:31 ` Michal Hocko
2017-04-28 9:17 ` Laurent Dufour
2017-04-28 13:48 ` Michal Hocko
2017-05-02 14:59 ` Laurent Dufour
2017-05-02 18:55 ` Michal Hocko
2017-05-03 11:34 ` Laurent Dufour
2017-05-04 1:21 ` Balbir Singh
2017-05-08 10:42 ` Laurent Dufour
2017-05-09 1:41 ` Balbir Singh
2017-05-08 2:58 ` Naoya Horiguchi
2017-05-09 9:18 ` Michal Hocko
2017-05-09 22:59 ` Naoya Horiguchi
2017-04-25 14:27 ` [PATCH v2 2/2] mm: skip HWPoisoned pages when onlining pages Laurent Dufour
2017-04-26 2:10 ` Balbir Singh
2017-04-26 3:13 ` Naoya Horiguchi
2017-04-28 2:51 ` Balbir Singh
2017-04-28 6:30 ` Michal Hocko
2017-04-28 6:50 ` Michal Hocko
2017-04-28 6:51 ` Michal Hocko
2017-05-10 7:41 ` Michal Hocko
2018-01-17 23:03 ` Andrew Morton
2018-01-23 18:15 ` Laurent Dufour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428060755.GA8143@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=ldufour@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).