From: Michal Hocko <mhocko@kernel.org>
To: zhouxianrong <zhouxianrong@huawei.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, vbabka@suse.cz,
alexander.h.duyck@intel.com, mgorman@suse.de,
l.stach@pengutronix.de, vdavydov.dev@gmail.com,
hannes@cmpxchg.org, minchan@kernel.org, npiggin@gmail.com,
kirill.shutemov@linux.intel.com, gi-oh.kim@profitbricks.com,
luto@kernel.org, keescook@chromium.org, mark.rutland@arm.com,
mingo@kernel.org, heiko.carstens@de.ibm.com,
iamjoonsoo.kim@lge.com, rientjes@google.com,
ming.ling@spreadtrum.com, jack@suse.cz, ebru.akagunduz@gmail.com,
bigeasy@linutronix.de, Mi.Sophia.Wang@huawei.com,
zhouxiyu@huawei.com, weidu.du@huawei.com, fanghua3@huawei.com,
won.ho.park@huawei.com
Subject: Re: [PATCH mm] introduce reverse buddy concept to reduce buddy fragment
Date: Tue, 4 Jul 2017 13:24:14 +0200 [thread overview]
Message-ID: <20170704112414.GA14727@dhcp22.suse.cz> (raw)
In-Reply-To: <d6eaccf6-dbc0-2d4e-2c51-0c9a40b79aa8@huawei.com>
On Tue 04-07-17 16:04:52, zhouxianrong wrote:
> every 2s i sample /proc/buddyinfo in the whole test process.
>
> the last about 90 samples were sampled after the test was done.
I've tried to explain to you that numbers without a proper testing
metodology and highlevel metrics you are interested in and comparision
to the base kernel are meaningless. I cannot draw any conclusion from
looking at numbers you have posted. Are high order allocations cheaper
to do with this patch? What about an averge order-0 allocation request?
You are touching memory allocator hot paths and those are really
sensitive to changes. It takes a lot of testing with different workloads
to prove that no new regressions are introduced. That being said, I
completely agree that reducing the memory fragmentation is an important
objective but touching the page allocator and adding new branches there
sounds like a problematic approach which would have to show _huge_
benefits to be mergeable. Is it possible to improve khugepaged to
accomplish the same thing?
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-07-04 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 11:25 [PATCH mm] introduce reverse buddy concept to reduce buddy fragment zhouxianrong
2017-07-03 7:48 ` Michal Hocko
2017-07-03 9:01 ` zhouxianrong
2017-07-03 12:02 ` zhouxianrong
2017-07-03 15:33 ` Michal Hocko
2017-07-04 1:21 ` zhouxianrong
2017-07-04 6:52 ` Michal Hocko
2017-07-04 7:00 ` zhouxianrong
2017-07-04 8:04 ` zhouxianrong
2017-07-04 11:24 ` Michal Hocko [this message]
2017-07-04 11:46 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2017-06-30 11:22 zhouxianrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704112414.GA14727@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=Mi.Sophia.Wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@intel.com \
--cc=bigeasy@linutronix.de \
--cc=ebru.akagunduz@gmail.com \
--cc=fanghua3@huawei.com \
--cc=gi-oh.kim@profitbricks.com \
--cc=hannes@cmpxchg.org \
--cc=heiko.carstens@de.ibm.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jack@suse.cz \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=ming.ling@spreadtrum.com \
--cc=mingo@kernel.org \
--cc=npiggin@gmail.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=weidu.du@huawei.com \
--cc=won.ho.park@huawei.com \
--cc=zhouxianrong@huawei.com \
--cc=zhouxiyu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).