From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f198.google.com (mail-wr0-f198.google.com [209.85.128.198]) by kanga.kvack.org (Postfix) with ESMTP id 0E8086B02F3 for ; Fri, 21 Jul 2017 10:39:29 -0400 (EDT) Received: by mail-wr0-f198.google.com with SMTP id 92so17073322wra.11 for ; Fri, 21 Jul 2017 07:39:29 -0700 (PDT) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com. [74.125.82.65]) by mx.google.com with ESMTPS id m9si5319606wrb.367.2017.07.21.07.39.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Jul 2017 07:39:27 -0700 (PDT) Received: by mail-wm0-f65.google.com with SMTP id p204so7229233wmg.1 for ; Fri, 21 Jul 2017 07:39:27 -0700 (PDT) From: Michal Hocko Subject: [PATCH 3/9] mm, page_alloc: do not set_cpu_numa_mem on empty nodes initialization Date: Fri, 21 Jul 2017 16:39:09 +0200 Message-Id: <20170721143915.14161-4-mhocko@kernel.org> In-Reply-To: <20170721143915.14161-1-mhocko@kernel.org> References: <20170721143915.14161-1-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Mel Gorman , Johannes Weiner , Vlastimil Babka , linux-mm@kvack.org, LKML , Michal Hocko From: Michal Hocko __build_all_zonelists reinitializes each online cpu local node for CONFIG_HAVE_MEMORYLESS_NODES. This makes sense because previously memory less nodes could gain some memory during memory hotplug and so the local node should be changed for CPUs close to such a node. It makes less sense to do that unconditionally for a newly creaded NUMA node which is still offline and without any memory. Let's also simplify the cpu loop and use for_each_online_cpu instead of an explicit cpu_online check for all possible cpus. Acked-by: Mel Gorman Acked-by: Vlastimil Babka Signed-off-by: Michal Hocko --- mm/page_alloc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index ff53f709c44c..52dc5ba40914 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5096,10 +5096,8 @@ static int __build_all_zonelists(void *data) build_zonelists(pgdat); } - } #ifdef CONFIG_HAVE_MEMORYLESS_NODES - for_each_possible_cpu(cpu) { /* * We now know the "local memory node" for each node-- * i.e., the node of the first zone in the generic zonelist. @@ -5108,10 +5106,10 @@ static int __build_all_zonelists(void *data) * secondary cpus' numa_mem as they come on-line. During * node/memory hotplug, we'll fixup all on-line cpus. */ - if (cpu_online(cpu)) + for_each_online_cpu(cpu) set_cpu_numa_mem(cpu, local_memory_node(cpu_to_node(cpu))); - } #endif + } return 0; } -- 2.11.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org