From: Andrew Morton <akpm@linux-foundation.org>
To: Oliver O'Halloran <oohall@gmail.com>
Cc: linux-mm@kvack.org, "Kirill A. Shutemov" <kirill@shutemov.name>
Subject: Re: [PATCH] mm/gup: Make __gup_device_* require THP
Date: Fri, 21 Jul 2017 16:13:22 -0700 [thread overview]
Message-ID: <20170721161322.98c5cd44b5b3612be0f7fe14@linux-foundation.org> (raw)
In-Reply-To: <20170626063833.11094-1-oohall@gmail.com>
On Mon, 26 Jun 2017 16:38:33 +1000 "Oliver O'Halloran" <oohall@gmail.com> wrote:
> These functions are the only bits of generic code that use
> {pud,pmd}_pfn() without checking for CONFIG_TRANSPARENT_HUGEPAGE.
> This works fine on x86, the only arch with devmap support, since the
> *_pfn() functions are always defined there, but this isn't true for
> every architecture.
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> ---
> mm/gup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index d9e6fddcc51f..04cf79291321 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -1287,7 +1287,7 @@ static int gup_pte_range(pmd_t pmd, unsigned long addr, unsigned long end,
> }
> #endif /* __HAVE_ARCH_PTE_SPECIAL */
>
> -#ifdef __HAVE_ARCH_PTE_DEVMAP
> +#if defined(__HAVE_ARCH_PTE_DEVMAP) && defined(CONFIG_TRANSPARENT_HUGEPAGE)
> static int __gup_device_huge(unsigned long pfn, unsigned long addr,
> unsigned long end, struct page **pages, int *nr)
> {
(cc Kirill)
Please provide a full description of the bug which is being fixed. I
assume it's a build error. What are the error messages and under what
circumstances.
Etcetera. Enough info for me (and others) to decide which kernel
version(s) need the fix.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-07-21 23:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 6:38 [PATCH] mm/gup: Make __gup_device_* require THP Oliver O'Halloran
2017-07-21 23:13 ` Andrew Morton [this message]
2017-07-22 3:49 ` Oliver
2017-07-23 21:34 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170721161322.98c5cd44b5b3612be0f7fe14@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).