From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Nadav Amit <namit@vmware.com>
Cc: linux-mm@kvack.org, sergey.senozhatsky@gmail.com,
minchan@kernel.org, nadav.amit@gmail.com, mgorman@suse.de,
riel@redhat.com, luto@kernel.org, stable@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 1/2] mm: migrate: prevent racy access to tlb_flush_pending
Date: Fri, 28 Jul 2017 10:34:23 +0900 [thread overview]
Message-ID: <20170728013423.GA358@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20170727114015.3452-2-namit@vmware.com>
just my 5 silly cents,
On (07/27/17 04:40), Nadav Amit wrote:
[..]
> static inline void set_tlb_flush_pending(struct mm_struct *mm)
> {
> - mm->tlb_flush_pending = true;
> + atomic_inc(&mm->tlb_flush_pending);
>
> /*
> * Guarantee that the tlb_flush_pending store does not leak into the
> @@ -544,7 +544,7 @@ static inline void set_tlb_flush_pending(struct mm_struct *mm)
> static inline void clear_tlb_flush_pending(struct mm_struct *mm)
> {
> barrier();
> - mm->tlb_flush_pending = false;
> + atomic_dec(&mm->tlb_flush_pending);
> }
so, _technically_, set_tlb_flush_pending() can be nested, right? IOW,
set_tlb_flush_pending()
set_tlb_flush_pending()
flush_tlb_range()
clear_tlb_flush_pending()
clear_tlb_flush_pending() // if we miss this one, then
// ->tlb_flush_pending is !clear,
// even though we called
// clear_tlb_flush_pending()
if so then set_ and clear_ are a bit misleading names for something
that does atomic_inc()/atomic_dec() internally.
especially when one sees this part
> - clear_tlb_flush_pending(mm);
> +#if defined(CONFIG_NUMA_BALANCING) || defined(CONFIG_COMPACTION)
> + atomic_set(&mm->tlb_flush_pending, 0);
> +#endif
so we have clear_tlb_flush_pending() function which probably should
set it to 0 as the name suggests (I see what you did tho), yet still
do atomic_set() under ifdef-s.
well, just nitpicks.
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-07-28 1:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 11:40 [PATCH v3 0/2] mm: fixes of tlb_flush_pending races Nadav Amit
2017-07-27 11:40 ` [PATCH v3 1/2] mm: migrate: prevent racy access to tlb_flush_pending Nadav Amit
2017-07-28 1:34 ` Sergey Senozhatsky [this message]
2017-07-28 1:44 ` Nadav Amit
2017-07-28 1:42 ` Sergey Senozhatsky
2017-07-28 2:28 ` Rik van Riel
2017-07-27 11:40 ` [PATCH v3 2/2] mm: migrate: fix barriers around tlb_flush_pending Nadav Amit
2017-07-28 7:42 ` Mel Gorman
2017-07-28 16:40 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728013423.GA358@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=nadav.amit@gmail.com \
--cc=namit@vmware.com \
--cc=riel@redhat.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).