From: Michal Hocko <mhocko@suse.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Josef Bacik <josef@toxicpanda.com>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Rik van Riel <riel@redhat.com>,
linux-mm@kvack.org
Subject: Re: [4.13-rc1] /proc/meminfo reports that Slab: is little used.
Date: Fri, 28 Jul 2017 15:34:22 +0200 [thread overview]
Message-ID: <20170728133421.GR2274@dhcp22.suse.cz> (raw)
In-Reply-To: <20170728130517.GA16849@cmpxchg.org>
On Fri 28-07-17 09:05:17, Johannes Weiner wrote:
> On Fri, Jul 28, 2017 at 11:07:51AM +0200, Michal Hocko wrote:
[...]
> > From: Michal Hocko <mhocko@suse.com>
> > Date: Fri, 28 Jul 2017 11:02:51 +0200
> > Subject: [PATCH] mm: rename global_page_state to global_zone_page_state
> >
> > global_page_state is error prone as a recent bug report pointed out [1].
> > It only returns proper values for zone based counters as the enum it
> > gets suggests. We already have global_node_page_state so let's rename
> > global_page_state to global_zone_page_state to be more explicit here.
> > All existing users seems to be correct
> > $ git grep "global_page_state(NR_" | sed 's@.*(\(NR_[A-Z_]*\)).*@\1@' | sort | uniq -c
> > 2 NR_BOUNCE
> > 2 NR_FREE_CMA_PAGES
> > 11 NR_FREE_PAGES
> > 1 NR_KERNEL_STACK_KB
> > 1 NR_MLOCK
> > 2 NR_PAGETABLE
> >
> > This patch shouldn't introduce any functional change.
> >
> > [1] http://lkml.kernel.org/r/201707260628.v6Q6SmaS030814@www262.sakura.ne.jp
> >
> > Signed-off-by: Michal Hocko <mhocko@suse.com>
>
> Yeah I think that's a good idea. I suspect Mel wanted to keep churn in
> unrelated callsites down when he introduced the node stuff, since that
> was already a big patch series. It makes sense to clean this up now.
yeah that would make sense.
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Thanks! Could you post both patches when sending to Andrew, please?
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-07-28 13:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 6:28 [4.13-rc1] /proc/meminfo reports that Slab: is little used Tetsuo Handa
2017-07-27 16:23 ` Johannes Weiner
2017-07-27 22:23 ` Tetsuo Handa
2017-07-28 9:07 ` Michal Hocko
2017-07-28 13:05 ` Johannes Weiner
2017-07-28 13:34 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728133421.GR2274@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=hannes@cmpxchg.org \
--cc=josef@toxicpanda.com \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=riel@redhat.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).