From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: akpm@linux-foundation.org, rientjes@google.com,
hannes@cmpxchg.org, guro@fb.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm, oom: do not rely on TIF_MEMDIE for memory reserves access
Date: Thu, 3 Aug 2017 10:21:04 +0200 [thread overview]
Message-ID: <20170803082104.GE12521@dhcp22.suse.cz> (raw)
In-Reply-To: <201708031703.HGC35950.LSJFOHQFtFMOVO@I-love.SAKURA.ne.jp>
On Thu 03-08-17 17:03:20, Tetsuo Handa wrote:
> Michal Hocko wrote:
> > Look, I really appreciate your sentiment for for nommu platform but with
> > an absolute lack of _any_ oom reports on that platform that I am aware
> > of nor any reports about lockups during oom I am less than thrilled to
> > add a code to fix a problem which even might not exist. Nommu is usually
> > very special with a very specific workload running (e.g. no overcommit)
> > so I strongly suspect that any OOM theories are highly academic.
>
> If you believe that there is really no oom report, get rid of the OOM
> killer completely.
I am not an user or even an owner of such a platform. As I've said all I
care about is to not regress for those guys and I believe that the patch
doesn't change nommu behavior in any risky way. If yes, point them out
and I will try to address them.
> > All I do care about is to not regress nommu as much as possible. So can
> > we get back to the proposed patch and updates I have done to address
> > your review feedback please?
>
> No unless we get rid of the OOM killer if CONFIG_MMU=n.
Are you saying that you are going to nack the patch based on this
reasoning? This is just ridiculous.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-08-03 8:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 9:03 [PATCH 0/2] mm, oom: do not grant oom victims full memory reserves access Michal Hocko
2017-07-27 9:03 ` [PATCH 1/2] mm, oom: do not rely on TIF_MEMDIE for " Michal Hocko
2017-08-01 15:30 ` Tetsuo Handa
2017-08-01 16:52 ` Michal Hocko
2017-08-02 6:10 ` Michal Hocko
2017-08-03 1:39 ` Tetsuo Handa
2017-08-03 7:06 ` Michal Hocko
2017-08-03 8:03 ` Tetsuo Handa
2017-08-03 8:21 ` Michal Hocko [this message]
2017-08-02 8:29 ` [PATCH v2 " Michal Hocko
2017-08-03 9:37 ` Mel Gorman
2017-08-03 11:00 ` Michal Hocko
2017-08-03 12:22 ` Mel Gorman
2017-07-27 9:03 ` [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim Michal Hocko
2017-07-27 14:01 ` Tetsuo Handa
2017-07-27 14:08 ` Tetsuo Handa
2017-07-27 14:18 ` Michal Hocko
2017-07-27 14:45 ` Michal Hocko
2017-07-27 14:55 ` Roman Gushchin
2017-07-29 8:33 ` kbuild test robot
2017-07-31 6:46 ` Michal Hocko
2017-08-01 12:16 ` [PATCH 0/2] mm, oom: do not grant oom victims full memory reserves access Michal Hocko
2017-08-01 12:23 ` Roman Gushchin
2017-08-01 12:29 ` Michal Hocko
2017-08-01 12:42 ` Roman Gushchin
2017-08-01 12:54 ` Michal Hocko
2017-08-07 14:21 ` Michal Hocko
2017-08-10 7:50 [PATCH v2 " Michal Hocko
2017-08-10 7:50 ` [PATCH 1/2] mm, oom: do not rely on TIF_MEMDIE for " Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803082104.GE12521@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).