From: David Miller <davem@davemloft.net>
To: khalid.aziz@oracle.com
Cc: akpm@linux-foundation.org, dave.hansen@linux.intel.com,
arnd@arndb.de, kirill.shutemov@linux.intel.com, mhocko@suse.com,
jack@suse.cz, ross.zwisler@linux.intel.com,
aneesh.kumar@linux.vnet.ibm.com, dave.jiang@intel.com,
willy@infradead.org, hughd@google.com, minchan@kernel.org,
hannes@cmpxchg.org, hillf.zj@alibaba-inc.com, shli@fb.com,
mingo@kernel.org, jmarchan@redhat.com, lstoakes@gmail.com,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, sparclinux@vger.kernel.org,
khalid@gonehiking.org
Subject: Re: [PATCH v7 2/9] mm, swap: Add infrastructure for saving page metadata on swap
Date: Tue, 15 Aug 2017 21:53:26 -0700 (PDT) [thread overview]
Message-ID: <20170815.215326.1833101229202321710.davem@davemloft.net> (raw)
In-Reply-To: <87ff7a44c45bd6a146102c6e6033ee7810d9ebb5.1502219353.git.khalid.aziz@oracle.com>
From: Khalid Aziz <khalid.aziz@oracle.com>
Date: Wed, 9 Aug 2017 15:25:55 -0600
> @@ -1399,6 +1399,12 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
> (flags & TTU_MIGRATION)) {
> swp_entry_t entry;
> pte_t swp_pte;
> +
> + if (arch_unmap_one(mm, vma, address, pteval) < 0) {
> + set_pte_at(mm, address, pvmw.pte, pteval);
> + ret = false;
> + page_vma_mapped_walk_done(&pvmw);
> + break;
> /*
> * Store the pfn of the page in a special migration
> * pte. do_swap_page() will wait until the migration
> @@ -1410,6 +1416,7 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
> if (pte_soft_dirty(pteval))
> swp_pte = pte_swp_mksoft_dirty(swp_pte);
> set_pte_at(mm, address, pvmw.pte, swp_pte);
> + }
This basic block doesn't look right. I think the new closing brace is
intended to be right after the new break; statement. If not at the
very least the indentation of the existing code in there needs to be
adjusted.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-08-16 4:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 21:25 [PATCH v7 0/9] Application Data Integrity feature introduced by SPARC M7 Khalid Aziz
2017-08-09 21:25 ` [PATCH v7 2/9] mm, swap: Add infrastructure for saving page metadata on swap Khalid Aziz
2017-08-16 4:53 ` David Miller [this message]
2017-08-16 14:34 ` Khalid Aziz
2017-08-09 21:26 ` [PATCH v7 7/9] mm: Add address parameter to arch_validate_prot() Khalid Aziz
2017-08-10 13:20 ` Michael Ellerman
2017-08-10 14:41 ` Khalid Aziz
2017-08-15 5:02 ` Michael Ellerman
2017-08-15 14:32 ` Khalid Aziz
2017-08-09 21:26 ` [PATCH v7 8/9] mm: Clear arch specific VM flags on protection change Khalid Aziz
2017-08-09 21:26 ` [PATCH v7 9/9] sparc64: Add support for ADI (Application Data Integrity) Khalid Aziz
2017-08-16 4:58 ` David Miller
2017-08-16 14:44 ` Khalid Aziz
2017-08-25 22:31 ` Anthony Yznaga
2017-08-30 22:27 ` Khalid Aziz
2017-08-30 22:38 ` David Miller
2017-08-30 23:23 ` Khalid Aziz
2017-08-31 0:09 ` David Miller
2017-08-31 16:38 ` Khalid Aziz
2017-09-01 5:38 ` Anthony Yznaga
2017-09-04 16:25 ` Pavel Machek
2017-09-05 21:44 ` David Miller
2017-09-06 22:32 ` Pavel Machek
2017-09-08 12:18 ` Steven Sistare
2017-09-06 14:10 ` Khalid Aziz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815.215326.1833101229202321710.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=jmarchan@redhat.com \
--cc=khalid.aziz@oracle.com \
--cc=khalid@gonehiking.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=mingo@kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=shli@fb.com \
--cc=sparclinux@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).