Linux-mm Archive on
 help / color / Atom feed
From: Andrew Morton <>
To: Prakash Gupta <>
Subject: Re: [PATCH 1/2] arm64: stacktrace: avoid listing stacktrace functions in stacktrace
Date: Wed, 30 Aug 2017 13:28:28 -0700
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, 30 Aug 2017 13:02:22 +0530 Prakash Gupta <> wrote:

> The stacktraces always begin as follows:
>  [<c00117b4>] save_stack_trace_tsk+0x0/0x98
>  [<c0011870>] save_stack_trace+0x24/0x28
>  ...
> This is because the stack trace code includes the stack frames for itself.
> This is incorrect behaviour, and also leads to "skip" doing the wrong thing
> (which is the number of stack frames to avoid recording.)
> Perversely, it does the right thing when passed a non-current thread.  Fix
> this by ensuring that we have a known constant number of frames above the
> main stack trace function, and always skip these.
> This was fixed for arch arm by Commit 3683f44c42e9 ("ARM: stacktrace: avoid
> listing stacktrace functions in stacktrace")

I can take this (with acks, please?)

3683f44c42e9 has a cc:stable but your patch does not.  Should it?

To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to  For more info on Linux MM,
see: .
Don't email: <a href=mailto:""> </a>

  parent reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30  7:32 Prakash Gupta
2017-08-30  7:32 ` [PATCH 2/2] mm, page_owner: Skip unnecessary stack_trace entries Prakash Gupta
2017-08-31  7:34   ` Vlastimil Babka
2017-09-01  5:00     ` Prakash Gupta
2017-08-30 20:28 ` Andrew Morton [this message]
2017-08-31  6:28   ` [PATCH 1/2] arm64: stacktrace: avoid listing stacktrace functions in stacktrace Prakash Gupta
2017-09-04 10:29   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mm Archive on

Archives are clonable:
	git clone --mirror linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ \
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone