From: Michal Hocko <mhocko@kernel.org>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm, sparse: fix typo in online_mem_sections
Date: Tue, 5 Sep 2017 09:37:30 +0200 [thread overview]
Message-ID: <20170905073730.4reirga47o4athse@dhcp22.suse.cz> (raw)
In-Reply-To: <20170905072836.i4dxrukevojty4ub@dhcp22.suse.cz>
On Tue 05-09-17 09:28:36, Michal Hocko wrote:
> On Tue 05-09-17 12:32:28, Anshuman Khandual wrote:
> > On 09/04/2017 04:52 PM, Michal Hocko wrote:
> > > From: Michal Hocko <mhocko@suse.com>
> > >
> > > online_mem_sections accidentally marks online only the first section in
> > > the given range. This is a typo which hasn't been noticed because I
> > > haven't tested large 2GB blocks previously. All users of
> >
> > Section sizes are normally less than 2GB. Could you please elaborate
> > why this never got noticed before ?
>
> Section size is 128MB which is the default block size as well. So we
> have one section per block. But if the amount of memory is very large
> (64GB - see probe_memory_block_size) then we have a 2GB memory blocks
> so multiple sections per block.
And just to clarify. Not that 64G would be too large but the original
patch has been merged in 4.13 so nobody probably managed to hit that
_yet_.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-05 7:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 11:22 [PATCH] mm, sparse: fix typo in online_mem_sections Michal Hocko
2017-09-05 7:02 ` Anshuman Khandual
2017-09-05 7:28 ` Michal Hocko
2017-09-05 7:37 ` Michal Hocko [this message]
2017-09-05 8:44 ` Anshuman Khandual
2017-09-06 8:18 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905073730.4reirga47o4athse@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).