From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: mhocko@suse.com
Cc: yuwang668899@gmail.com, vbabka@suse.cz, mpatocka@redhat.com,
hannes@cmpxchg.org, mgorman@suse.de, dave.hansen@intel.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
chenggang.qcg@alibaba-inc.com, yuwang.yuwang@alibaba-inc.com
Subject: Re: [PATCH] mm,page_alloc: softlockup on warn_alloc on
Date: Fri, 15 Sep 2017 21:09:29 +0900 [thread overview]
Message-ID: <201709152109.AID48261.FtHOFMFQOJVLOS@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20170915120020.diakzyzsx73ygnfx@dhcp22.suse.cz>
Michal Hocko wrote:
> On Fri 15-09-17 20:38:49, Tetsuo Handa wrote:
> [...]
> > You said "identify _why_ we see the lockup trigerring in the first
> > place" without providing means to identify it. Unless you provide
> > means to identify it (in a form which can be immediately and easily
> > backported to 4.9 kernels; that is, backporting not-yet-accepted
> > printk() offloading patchset is not a choice), this patch cannot be
> > refused.
>
> I fail to see why. It simply workarounds an existing problem elsewhere
> in the kernel without deeper understanding on where the problem is. You
> can add your own instrumentation to debug and describe the problem. This
> is no different to any other kernel bugs...
Please do show us your patch for that. Normal users cannot afford developing
such instrumentation to debug and describe the problem.
>
> If our printk implementation is so weak it cannot cope with writers then
> that should be fixed without spreading hacks in different subsystems. If
> the lockup is a real problem under normal workloads (rather than
> artificial ones) then we should try to throttle more aggresively.
No throttle please. Throttling makes warn_alloc() more and more useless.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-15 12:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 9:58 [PATCH] mm,page_alloc: softlockup on warn_alloc on wang Yu
2017-09-15 10:39 ` Michal Hocko
2017-09-15 11:38 ` Tetsuo Handa
2017-09-15 12:00 ` Michal Hocko
2017-09-15 12:09 ` Tetsuo Handa [this message]
2017-09-15 12:14 ` Michal Hocko
2017-09-15 14:12 ` Tetsuo Handa
2017-09-15 14:23 ` Michal Hocko
2017-09-24 1:56 ` Tetsuo Handa
2017-09-15 14:37 ` Johannes Weiner
2017-09-15 15:23 ` Tetsuo Handa
2017-09-15 18:44 ` Johannes Weiner
2017-09-16 0:25 ` Tetsuo Handa
2017-09-18 6:05 ` Michal Hocko
2017-09-18 6:31 ` Tetsuo Handa
2017-09-18 6:43 ` Michal Hocko
2017-09-16 4:12 ` Tetsuo Handa
2017-10-11 11:14 ` Tetsuo Handa
2017-10-18 10:54 ` Tetsuo Handa
2017-09-18 6:03 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201709152109.AID48261.FtHOFMFQOJVLOS@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=chenggang.qcg@alibaba-inc.com \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mpatocka@redhat.com \
--cc=vbabka@suse.cz \
--cc=yuwang.yuwang@alibaba-inc.com \
--cc=yuwang668899@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).