From: Catalin Marinas <catalin.marinas@arm.com>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmemleak: change /sys/kernel/debug/kmemleak permissions from 0444 to 0644
Date: Fri, 6 Oct 2017 14:55:55 +0100 [thread overview]
Message-ID: <20171006135554.eiwezlqq6gyhy6wa@armageddon.cambridge.arm.com> (raw)
In-Reply-To: <150728996582.744328.11541332857988399411.stgit@buzz>
On Fri, Oct 06, 2017 at 02:39:25PM +0300, Konstantin Khlebnikov wrote:
> Kmemleak could be tweaked in runtime by writing commands into debugfs file.
> Root anyway can use it, but without write-bit this interface isn't obvious.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> ---
> mm/kmemleak.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> index 7780cd83a495..fca3452e56c1 100644
> --- a/mm/kmemleak.c
> +++ b/mm/kmemleak.c
> @@ -2104,7 +2104,7 @@ static int __init kmemleak_late_init(void)
> return -ENOMEM;
> }
>
> - dentry = debugfs_create_file("kmemleak", S_IRUGO, NULL, NULL,
> + dentry = debugfs_create_file("kmemleak", 0644, NULL, NULL,
> &kmemleak_fops);
> if (!dentry)
> pr_warn("Failed to create the debugfs kmemleak file\n");
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
--
Catalin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-10-06 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 11:39 [PATCH] kmemleak: change /sys/kernel/debug/kmemleak permissions from 0444 to 0644 Konstantin Khlebnikov
2017-10-06 13:55 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171006135554.eiwezlqq6gyhy6wa@armageddon.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).