Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
From: Srividya Desireddy <srividya.dr@samsung.com>
To: "sjenning@redhat.com" <sjenning@redhat.com>,
	Matthew Wilcox <willy@infradead.org>,
	Timofey Titovets <nefelim4ag@gmail.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"penberg@kernel.org" <penberg@kernel.org>,
	Dinakar Reddy Pathireddy <dinakar.p@samsung.com>,
	SHARAN ALLUR <sharan.allur@samsung.com>,
	RAJIB BASU <rajib.basu@samsung.com>,
	JUHUN KIM <juhunkim@samsung.com>,
	"srividya.desireddy@gmail.com" <srividya.desireddy@gmail.com>
Subject: Re: [PATCH] zswap: Same-filled pages handling
Date: Thu, 02 Nov 2017 15:08:20 +0000
Message-ID: <20171102150820epcms5p307052ef7697592b3b4e2848bf4968f7b@epcms5p3> (raw)
In-Reply-To: <20171019010841.GA17308@bombadil.infradead.org>

 
On Wed, Oct 19, 2017 at 6:38 AM, Matthew Wilcox wrote: 
> On Thu, Oct 19, 2017 at 12:31:18AM +0300, Timofey Titovets wrote:
>> > +static void zswap_fill_page(void *ptr, unsigned long value)
>> > +{
>> > +       unsigned int pos;
>> > +       unsigned long *page;
>> > +
>> > +       page = (unsigned long *)ptr;
>> > +       if (value == 0)
>> > +               memset(page, 0, PAGE_SIZE);
>> > +       else {
>> > +               for (pos = 0; pos < PAGE_SIZE / sizeof(*page); pos++)
>> > +                       page[pos] = value;
>> > +       }
>> > +}
>> 
>> Same here, but with memcpy().
>
>No.  Use memset_l which is optimised for this specific job.

I have tested this patch using memset_l() function in zswap_fill_page() on 
x86 64-bit system with 2GB RAM. The performance remains same. 
But, memset_l() funcion might be optimised in future. 
@Seth Jennings/Dan Streetman:  Should I use memset_l() function in this patch.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply index

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p1>
2017-10-18 10:48 ` Srividya Desireddy
2017-10-18 12:34   ` Matthew Wilcox
2017-10-18 13:33     ` Timofey Titovets
2017-10-18 14:11       ` Matthew Wilcox
2017-10-18 20:43   ` Andi Kleen
2017-10-19  1:10     ` Matthew Wilcox
2017-10-19  4:30       ` Andi Kleen
2017-10-19 13:24         ` Matthew Wilcox
2017-10-18 21:31   ` Timofey Titovets
2017-10-19  1:08     ` Matthew Wilcox
     [not found]     ` <CGME20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p3>
2017-11-02 15:08       ` Srividya Desireddy [this message]
2017-11-17 22:10         ` Dan Streetman
2017-11-17 22:07     ` Dan Streetman
2017-11-17 21:27   ` Dan Streetman
2017-11-20 23:46   ` Andrew Morton
2017-11-28 11:35     ` Dan Streetman
     [not found]     ` <CGME20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p6>
2017-11-29 15:34       ` [PATCH] zswap: Update with same-value filled page feature Srividya Desireddy
2017-11-29 21:29         ` Dan Streetman
2017-12-06 11:48       ` [PATCH v2] " Srividya Desireddy
2017-12-06 15:20         ` Dan Streetman
     [not found]   ` <CGME20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p4>
2017-11-21 14:18     ` [PATCH v2] zswap: Same-filled pages handling Srividya Desireddy
2017-10-18 14:43 ` [PATCH] " Srividya Desireddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102150820epcms5p307052ef7697592b3b4e2848bf4968f7b@epcms5p3 \
    --to=srividya.dr@samsung.com \
    --cc=dinakar.p@samsung.com \
    --cc=juhunkim@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nefelim4ag@gmail.com \
    --cc=penberg@kernel.org \
    --cc=rajib.basu@samsung.com \
    --cc=sharan.allur@samsung.com \
    --cc=sjenning@redhat.com \
    --cc=srividya.desireddy@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git