From: Michal Hocko <mhocko@kernel.org> To: Andrew Morton <akpm@linux-foundation.org>, Johannes Weiner <hannes@cmpxchg.org> Cc: Vlastimil Babka <vbabka@suse.cz>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com> Subject: [PATCH] mm, sparse: do not swamp log with huge vmemmap allocation failures Date: Mon, 6 Nov 2017 10:22:28 +0100 Message-ID: <20171106092228.31098-1-mhocko@kernel.org> (raw) From: Michal Hocko <mhocko@suse.com> While doing a memory hotplug tests under a heavy memory pressure we have noticed too many page allocation failures when allocating vmemmap memmap backed by huge page [146792.281354] kworker/u3072:1: page allocation failure: order:9, mode:0x24084c0(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO) [...] [146792.281394] Call Trace: [146792.281430] [<ffffffff81019a99>] dump_trace+0x59/0x310 [146792.281436] [<ffffffff81019e3a>] show_stack_log_lvl+0xea/0x170 [146792.281440] [<ffffffff8101abc1>] show_stack+0x21/0x40 [146792.281448] [<ffffffff8130f040>] dump_stack+0x5c/0x7c [146792.281464] [<ffffffff8118c982>] warn_alloc_failed+0xe2/0x150 [146792.281471] [<ffffffff8118cddd>] __alloc_pages_nodemask+0x3ed/0xb20 [146792.281489] [<ffffffff811d3aaf>] alloc_pages_current+0x7f/0x100 [146792.281503] [<ffffffff815dfa2c>] vmemmap_alloc_block+0x79/0xb6 [146792.281510] [<ffffffff815dfbd3>] __vmemmap_alloc_block_buf+0x136/0x145 [146792.281524] [<ffffffff815dd0c5>] vmemmap_populate+0xd2/0x2b9 [146792.281529] [<ffffffff815dffd9>] sparse_mem_map_populate+0x23/0x30 [146792.281532] [<ffffffff815df88d>] sparse_add_one_section+0x68/0x18e [146792.281537] [<ffffffff815d9f5a>] __add_pages+0x10a/0x1d0 [146792.281553] [<ffffffff8106249a>] arch_add_memory+0x4a/0xc0 [146792.281559] [<ffffffff815da1f9>] add_memory_resource+0x89/0x160 [146792.281564] [<ffffffff815da33d>] add_memory+0x6d/0xd0 [146792.281585] [<ffffffff813d36c4>] acpi_memory_device_add+0x181/0x251 [146792.281597] [<ffffffff813946e5>] acpi_bus_attach+0xfd/0x19b [146792.281602] [<ffffffff81394866>] acpi_bus_scan+0x59/0x69 [146792.281604] [<ffffffff813949de>] acpi_device_hotplug+0xd2/0x41f [146792.281608] [<ffffffff8138db67>] acpi_hotplug_work_fn+0x1a/0x23 [146792.281623] [<ffffffff81093cee>] process_one_work+0x14e/0x410 [146792.281630] [<ffffffff81094546>] worker_thread+0x116/0x490 [146792.281637] [<ffffffff810999ed>] kthread+0xbd/0xe0 [146792.281651] [<ffffffff815e4e7f>] ret_from_fork+0x3f/0x70 and we do see many of those because essentially every the allocation failes for each memory section. This is overly excessive way to tell user that there is nothing to really worry about because we do have a fallback mechanism to use base pages. The only downside might be a performance degradation due to TLB pressure. This patch changes vmemmap_alloc_block to use __GFP_NOWARN and warn explicitly once on the first allocation failure. This will reduce the noise in the kernel log considerably, while we still have an indication that a performance might be impacted. Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> Signed-off-by: Michal Hocko <mhocko@suse.com> --- Hi, this has somehow fell of my radar completely. The patch is essentially what Johannes suggested [1] so I have added his s-o-b and added the changelog into it. Can we have this merged? [1] http://lkml.kernel.org/r/20170711214541.GA11141@cmpxchg.org arch/x86/mm/init_64.c | 1 - mm/sparse-vmemmap.c | 11 +++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 126e09625979..5eb954f930be 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -1405,7 +1405,6 @@ static int __meminit vmemmap_populate_hugepages(unsigned long start, vmemmap_verify((pte_t *)pmd, node, addr, next); continue; } - pr_warn_once("vmemmap: falling back to regular page backing\n"); if (vmemmap_populate_basepages(addr, next, node)) return -ENOMEM; } diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index d0860aab1c89..3f85084cb8bb 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -52,12 +52,19 @@ void * __meminit vmemmap_alloc_block(unsigned long size, int node) { /* If the main allocator is up use that, fallback to bootmem. */ if (slab_is_available()) { + gfp_t gfp_mask = GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_NOWARN; + int order = get_order(size); + static bool warned; struct page *page; - page = alloc_pages_node(node, GFP_KERNEL | __GFP_RETRY_MAYFAIL, - get_order(size)); + page = alloc_pages_node(node, gfp_mask, order); if (page) return page_address(page); + + if (!warned) { + warn_alloc(gfp_mask, NULL, "vmemmap alloc failure: order:%u", order); + warned = true; + } return NULL; } else return __earlyonly_bootmem_alloc(node, size, size, -- 2.14.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply index Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-06 9:22 Michal Hocko [this message] 2017-11-06 17:35 ` Johannes Weiner 2017-11-06 17:57 ` Joe Perches 2017-11-06 18:14 ` Khalid Aziz 2017-11-06 18:18 ` Michal Hocko 2017-11-06 20:17 ` Khalid Aziz [not found] ` <20171106205644.29386-11-mathieu.desnoyers@efficios.com> 2017-11-07 0:37 ` [RFC PATCH for 4.15 10/14] cpu_opv: Wire up powerpc system call Nicholas Piggin 2017-11-07 0:47 ` Mathieu Desnoyers 2017-11-07 1:21 ` Nicholas Piggin 2017-11-07 9:06 ` [PATCH] mm, sparse: do not swamp log with huge vmemmap allocation failures Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171106092228.31098-1-mhocko@kernel.org \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.com \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-mm Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \ linux-mm@kvack.org public-inbox-index linux-mm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kvack.linux-mm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git