Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/page_alloc: Avoid KERN_CONT uses in warn_alloc
Date: Thu, 9 Nov 2017 11:05:31 +0100
Message-ID: <20171109100531.3cn2hcqnuj7mjaju@dhcp22.suse.cz> (raw)
In-Reply-To: <1510070607.1000.23.camel@perches.com>

On Tue 07-11-17 08:03:27, Joe Perches wrote:
> On Tue, 2017-11-07 at 16:43 +0100, Michal Hocko wrote:
> > On Tue 07-11-17 07:34:25, Joe Perches wrote:
> []
> > > I believe, but have not tested, that using a specific width
> > > as an argument to %*pb[l] will constrain the number of
> > > spaces before the '(null)' output in any NULL pointer use.
> > > 
> > > So how about a #define like
> > > 
> > > /*
> > >  * nodemask_pr_args is only used with a "%*pb[l]" format for a nodemask.
> > >  * A NULL nodemask uses 6 to emit "(null)" without leading spaces.
> > >  */
> > > #define nodemask_pr_args(maskp)			\
> > > 	(maskp) ? MAX_NUMNODES : 6,		\
> > > 	(maskp) ? (maskp)->bits : NULL
> > 
> > Why not -1 then?
> 
> I believe it's the field width and not the precision that
> needs to be set.

But the first of the two arguments is the field with specifier, not the
precision. /me confused...

Anyway, the following works as expected when printing the OOM report:
[   47.005321] mem_eater invoked oom-killer: gfp_mask=0x14280ca(GFP_HIGHUSER_MOVABLE|__GFP_ZERO), nodemask=(null), order=0, oom_score_adj=0
[   47.007183] mem_eater cpuset=/ mems_allowed=0-1
[   47.007829] CPU: 3 PID: 3223 Comm: mem_eater Tainted: G        W       4.13.0-pr1-dirty #11

I hope I haven't overlooked anything
---

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 18:02 Joe Perches
2017-11-07 12:50 ` Michal Hocko
2017-11-07 15:34   ` Joe Perches
2017-11-07 15:43     ` Michal Hocko
2017-11-07 16:03       ` Joe Perches
2017-11-09 10:05         ` Michal Hocko [this message]
2017-11-09 15:49           ` Joe Perches
2017-11-09 16:03             ` Michal Hocko
2017-11-09 16:27           ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171109100531.3cn2hcqnuj7mjaju@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git