From: Michal Hocko <mhocko@kernel.org>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: hughd@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: shmem: remove unused info variable
Date: Thu, 16 Nov 2017 14:17:43 +0100 [thread overview]
Message-ID: <20171116131743.xwgljzw62eyzqwiw@dhcp22.suse.cz> (raw)
In-Reply-To: <1510774029-30652-1-git-send-email-clabbe@baylibre.com>
This seems familiar. Ohh, you have posted it
http://lkml.kernel.org/r/20171021165032.20542-1-clabbe.montjoie@gmail.com
already. It fall though cracks, it seems. CCing Andrew
On Wed 15-11-17 19:27:09, Corentin Labbe wrote:
> This patch fix the following build warning by simply removing the unused
> info variable.
> mm/shmem.c:3205:27: warning: variable 'info' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/shmem.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 544c105d706a..7fbe67be86fa 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -3202,7 +3202,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
> int len;
> struct inode *inode;
> struct page *page;
> - struct shmem_inode_info *info;
>
> len = strlen(symname) + 1;
> if (len > PAGE_SIZE)
> @@ -3222,7 +3221,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
> error = 0;
> }
>
> - info = SHMEM_I(inode);
> inode->i_size = len-1;
> if (len <= SHORT_SYMLINK_LEN) {
> inode->i_link = kmemdup(symname, len, GFP_KERNEL);
> --
> 2.13.6
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-16 13:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 19:27 [PATCH] mm: shmem: remove unused info variable Corentin Labbe
2017-11-16 13:17 ` Michal Hocko [this message]
2017-11-16 13:18 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116131743.xwgljzw62eyzqwiw@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=clabbe@baylibre.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).