From: Mel Gorman <mgorman@techsingularity.net>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, kernel@pengutronix.de,
patchwork-lst@pengutronix.de
Subject: Re: [PATCH] mm: page_alloc: avoid excessive IRQ disabled times in free_unref_page_list
Date: Fri, 8 Dec 2017 11:38:56 +0000 [thread overview]
Message-ID: <20171208113856.7352reah7xebvp7a@techsingularity.net> (raw)
In-Reply-To: <1512727403.11506.21.camel@pengutronix.de>
On Fri, Dec 08, 2017 at 11:03:23AM +0100, Lucas Stach wrote:
> Am Donnerstag, den 07.12.2017, 19:51 +0000 schrieb Mel Gorman:
> > On Thu, Dec 07, 2017 at 06:03:14PM +0100, Lucas Stach wrote:
> > > Since 9cca35d42eb6 (mm, page_alloc: enable/disable IRQs once when
> > > freeing
> > > a list of pages) we see excessive IRQ disabled times of up to 250ms
> > > on an
> > > embedded ARM system (tracing overhead included).
> > >
> > > This is due to graphics buffers being freed back to the system via
> > > release_pages(). Graphics buffers can be huge, so it's not hard to
> > > hit
> > > cases where the list of pages to free has 2048 entries. Disabling
> > > IRQs
> > > while freeing all those pages is clearly not a good idea.
> > >
> >
> > 250ms to free 2048 entries? That seems excessive but I guess the
> > embedded ARM system is not that fast.
>
> Urgh, yes, I've messed up the order of magnitude in the commit log. It
> really is on the order of 25ms. Which is still prohibitively long for
> an IRQs off section.
>
Ok, 25ms is more plausible but I agree that it's still an excessive
amount of time to have IRQs disabled. The problem still needs fixing but
I'd like to see Andrew's approach at least attempted as it should
achieve the same goal while being slightly nicer from a cache hotness
perspective.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-12-08 11:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 17:03 [PATCH] mm: page_alloc: avoid excessive IRQ disabled times in free_unref_page_list Lucas Stach
2017-12-07 19:51 ` Mel Gorman
2017-12-07 23:20 ` Andrew Morton
2017-12-08 0:25 ` Mel Gorman
2017-12-08 0:53 ` Andrew Morton
2017-12-08 10:21 ` Mel Gorman
2017-12-08 10:03 ` Lucas Stach
2017-12-08 11:38 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208113856.7352reah7xebvp7a@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=patchwork-lst@pengutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).