From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f197.google.com (mail-wr0-f197.google.com [209.85.128.197]) by kanga.kvack.org (Postfix) with ESMTP id 342416B0038 for ; Fri, 22 Dec 2017 10:12:11 -0500 (EST) Received: by mail-wr0-f197.google.com with SMTP id k44so11124872wre.1 for ; Fri, 22 Dec 2017 07:12:11 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id 61si14476971wrj.86.2017.12.22.07.12.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Dec 2017 07:12:10 -0800 (PST) Date: Fri, 22 Dec 2017 16:12:10 +0100 From: Greg Kroah-Hartman Subject: Re: [PATCH 4.14 023/159] mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y Message-ID: <20171222151210.GB6874@kroah.com> References: <20171222084623.668990192@linuxfoundation.org> <20171222084625.007160464@linuxfoundation.org> <20171222141810.dpeozmylmnj253do@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Naresh Kamboju Cc: linux-kernel@vger.kernel.org, linux- stable , "Kirill A. Shutemov" , Andrew Morton , Andy Lutomirski , Borislav Petkov , Cyrill Gorcunov , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , linux-mm@kvack.org, Ingo Molnar On Fri, Dec 22, 2017 at 08:22:09PM +0530, Naresh Kamboju wrote: > On 22 December 2017 at 19:48, Dan Rue wrote: > > On Fri, Dec 22, 2017 at 09:45:08AM +0100, Greg Kroah-Hartman wrote: > >> 4.14-stable review patch. If anyone has any objections, please let me know. > >> > >> ------------------ > >> > >> From: Kirill A. Shutemov > >> > >> commit 83e3c48729d9ebb7af5a31a504f3fd6aff0348c4 upstream. > >> > >> Size of the mem_section[] array depends on the size of the physical address space. > >> > >> In preparation for boot-time switching between paging modes on x86-64 > >> we need to make the allocation of mem_section[] dynamic, because otherwise > >> we waste a lot of RAM: with CONFIG_NODE_SHIFT=10, mem_section[] size is 32kB > >> for 4-level paging and 2MB for 5-level paging mode. > >> > >> The patch allocates the array on the first call to sparse_memory_present_with_active_regions(). > >> > >> Signed-off-by: Kirill A. Shutemov > >> Cc: Andrew Morton > >> Cc: Andy Lutomirski > >> Cc: Borislav Petkov > >> Cc: Cyrill Gorcunov > >> Cc: Linus Torvalds > >> Cc: Peter Zijlstra > >> Cc: Thomas Gleixner > >> Cc: linux-mm@kvack.org > >> Link: http://lkml.kernel.org/r/20170929140821.37654-2-kirill.shutemov@linux.intel.com > >> Signed-off-by: Ingo Molnar > >> Signed-off-by: Greg Kroah-Hartman > > > > This patch causes a boot failure on arm64. > > > > Please drop this patch, or pick up the fix in: > > > > commit 629a359bdb0e0652a8227b4ff3125431995fec6e > > Author: Kirill A. Shutemov > > Date: Tue Nov 7 11:33:37 2017 +0300 > > > > mm/sparsemem: Fix ARM64 boot crash when CONFIG_SPARSEMEM_EXTREME=y > > > > See https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1527427.html > > +1. > Boot failed on arm64 without 629a359b > mm/sparsemem: Fix ARM64 boot crash when CONFIG_SPARSEMEM_EXTREME=y > > Boot Error log: > -------------------- > [ 0.000000] Unable to handle kernel NULL pointer dereference at > virtual address 00000000 > [ 0.000000] Mem abort info: > [ 0.000000] Exception class = DABT (current EL), IL = 32 bits > [ 0.000000] SET = 0, FnV = 0 > [ 0.000000] EA = 0, S1PTW = 0 > [ 0.000000] Data abort info: > [ 0.000000] ISV = 0, ISS = 0x00000004 > [ 0.000000] CM = 0, WnR = 0 > [ 0.000000] [0000000000000000] user address but active_mm is swapper > [ 0.000000] Internal error: Oops: 96000004 [#1] PREEMPT SMP > [ 0.000000] Modules linked in: > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 4.14.9-rc1 #1 > [ 0.000000] Hardware name: ARM Juno development board (r2) (DT) > [ 0.000000] task: ffff0000091d9380 task.stack: ffff0000091c0000 > [ 0.000000] PC is at memory_present+0x64/0xf4 > [ 0.000000] LR is at memory_present+0x38/0xf4 > [ 0.000000] pc : [] lr : [] > pstate: 800000c5 > [ 0.000000] sp : ffff0000091c3e80 > > More information, > https://pastebin.com/KambxUwb -rc2 is out with the fix, hopefully that survives longer :) thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org